Bug 168724 – XMLHttpRequest: do not sniff text/html, and do not sniff XML when responseType is set to "text"

• Component: DOM
• Status: RESOLVED FIXED

[Anne van Kesteren]

See http://w3c-test.org/XMLHttpRequest/responsetext-decoding.htm.

Context: https://github.com/w3c/web-platform-tests/pull/4935.

[Chris Dumez]

Blink patch:
https://bugs.chromium.org/p/chromium/issues/detail?id=695045

[Chris Dumez]

Created attachment 323424 [details]
WIP Patch

[Chris Dumez]

Created attachment 323453 [details]
Patch

[Chris Dumez]

Created attachment 323455 [details]
Patch

[Build Bot]

Comment on attachment 323455 [details]
Patch

Attachment 323455 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4827931

New failing tests:
http/tests/xmlhttprequest/response-encoding.html

[Build Bot]

Created attachment 323461 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 323455 [details]
Patch

Attachment 323455 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4827990

New failing tests:
http/tests/xmlhttprequest/response-encoding.html

[Build Bot]

Created attachment 323462 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 323455 [details]
Patch

Attachment 323455 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4828066

New failing tests:
http/tests/xmlhttprequest/response-encoding.html

[Build Bot]

Created attachment 323463 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Chris Dumez]

Created attachment 323465 [details]
Patch

[youenn fablet]

Patch seems fine.
I guess the compat issue is really low since Chrome probably shipped this a while ago.

[Chris Dumez]

(In reply to youenn fablet from comment #12)
> Patch seems fine.
> I guess the compat issue is really low since Chrome probably shipped this a
> while ago.

Full disclosure, the Blink patch landed yesterday so they did not ship this yet. They will definitely ship it before us though and we can always revert if they run into trouble.

[youenn fablet]

Do you know what IE/MS are doing here?

[youenn fablet]

IE/Firefox...

[Chris Dumez]

(In reply to youenn fablet from comment #15)
> IE/Firefox...

I do not know about IE but Firefox aligned with the spec. Info available at:
- https://github.com/w3c/web-platform-tests/pull/4935
- https://bugzilla.mozilla.org/show_bug.cgi?id=1341260

So basically, both Firefox and Chrome aligned. Anne may know about IE / Edge.

[Ryosuke Niwa]

Comment on attachment 323465 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323465&action=review

> Source/WebCore/xml/XMLHttpRequest.cpp:1062
> +        }

Don't we need to check if the response is HTML? We used to do that in the old code.

[Chris Dumez]

Comment on attachment 323465 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323465&action=review

>> Source/WebCore/xml/XMLHttpRequest.cpp:1062
>> +        }
> 
> Don't we need to check if the response is HTML? We used to do that in the old code.

No, if I add this check then a WPT subtest would no longer start passing.

Also note that Chrome is not doing the HTML check either in this case.

> LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/responsetext-decoding-expected.txt:3
> +PASS XMLHttpRequest: responseText decoding (text/html %3C!doctype%20html%3E%3Cmeta%20charset%3Dwindows-1252%3E%3Cx%3E%e6%a9%9f%3C%2Fx%3E empty) 

This subtest would fail again.

[WebKit Commit Bot]

Comment on attachment 323465 [details]
Patch

Clearing flags on attachment: 323465

Committed r223217: <https://trac.webkit.org/changeset/223217>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34946063>