Bug 168717

Summary: [GStreamer][EME] Fix issue with allowed systems extraction
Product: WebKit Reporter: Xabier Rodríguez Calvar <calvaris>
Component: New BugsAssignee: Xabier Rodríguez Calvar <calvaris>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, zan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Xabier Rodríguez Calvar
Reported 2017-02-22 04:28:28 PST
[GStreamer][EME] Fix issue with allowed systems extraction
Attachments
Patch (2.43 KB, patch)
2017-02-22 04:30 PST, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Xabier Rodríguez Calvar
Comment 1 2017-02-22 04:30:24 PST
Created attachment 302386 [details] Patch
Carlos Garcia Campos
Comment 2 2017-02-22 04:41:23 PST
Comment on attachment 302386 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302386&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:271 > unsigned i; > - for (i = 0; !streamEncryptionAllowedSystems[i]; ++i) > + for (i = 0; streamEncryptionAllowedSystems[i]; ++i) for (unsigned i = 0
Xabier Rodríguez Calvar
Comment 3 2017-02-22 08:38:56 PST
Comment on attachment 302386 [details] Patch (In reply to comment #2) > Comment on attachment 302386 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=302386&action=review > > > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:271 > > unsigned i; > > - for (i = 0; !streamEncryptionAllowedSystems[i]; ++i) > > + for (i = 0; streamEncryptionAllowedSystems[i]; ++i) > > for (unsigned i = 0 I can't, i is used later.
WebKit Commit Bot
Comment 4 2017-02-22 08:56:31 PST
Comment on attachment 302386 [details] Patch Clearing flags on attachment: 302386 Committed r212830: <http://trac.webkit.org/changeset/212830>
WebKit Commit Bot
Comment 5 2017-02-22 08:56:35 PST
All reviewed patches have been landed. Closing bug.
Carlos Garcia Campos
Comment 6 2017-02-22 08:57:15 PST
(In reply to comment #3) > Comment on attachment 302386 [details] > Patch > > (In reply to comment #2) > > Comment on attachment 302386 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=302386&action=review > > > > > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:271 > > > unsigned i; > > > - for (i = 0; !streamEncryptionAllowedSystems[i]; ++i) > > > + for (i = 0; streamEncryptionAllowedSystems[i]; ++i) > > > > for (unsigned i = 0 > > I can't, i is used later. It's used later in a similar for loop that should do the same.
Xabier Rodríguez Calvar
Comment 7 2017-02-22 08:59:55 PST
(In reply to comment #6) > It's used later in a similar for loop that should do the same. Roger for the next time.
Note You need to log in before you can comment on or make changes to this bug.