Bug 168700

Summary: Do not aggressively throttle DOM timers until they've reached their max nesting level
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, commit-queue, dbates, esprehn+autocc, kangil.han
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 118301    
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews121 for ios-simulator-wk2
none
Patch none

Chris Dumez
Reported 2017-02-21 19:01:41 PST
Do not aggressively throttle DOM timers until they've reached their max nesting level. This is what's causing Google Maps to use 100% CPU usage in background tabs for several minutes.
Attachments
Patch (2.03 KB, patch)
2017-02-21 19:03 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (11.44 KB, patch)
2017-02-22 09:21 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (964.68 KB, application/zip)
2017-02-22 10:23 PST, Build Bot 		no flags
Details
Patch (12.25 KB, patch)
2017-02-22 10:26 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-02-21 19:02:03 PST
<rdar://problem/29808005>
Chris Dumez
Comment 2 2017-02-21 19:03:55 PST
Created attachment 302354 [details] Patch
Simon Fraser (smfr)
Comment 3 2017-02-21 19:40:58 PST
Comment on attachment 302354 [details] Patch Is there a way to test this?
Chris Dumez
Comment 4 2017-02-21 19:53:58 PST
(In reply to comment #3) > Comment on attachment 302354 [details] > Patch > > Is there a way to test this? Maybe. I'll look into it tomorrow.
Chris Dumez
Comment 5 2017-02-22 09:21:48 PST
Created attachment 302405 [details] Patch
Build Bot
Comment 6 2017-02-22 10:23:26 PST
Comment on attachment 302405 [details] Patch Attachment 302405 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3173399 New failing tests: fast/dom/timer-throttling-hidden-page.html
Build Bot
Comment 7 2017-02-22 10:23:30 PST
Created attachment 302409 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Chris Dumez
Comment 8 2017-02-22 10:26:17 PST
Created attachment 302411 [details] Patch
WebKit Commit Bot
Comment 9 2017-02-22 12:46:17 PST
Comment on attachment 302411 [details] Patch Clearing flags on attachment: 302411 Committed r212845: <http://trac.webkit.org/changeset/212845>
WebKit Commit Bot
Comment 10 2017-02-22 12:46:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.