Summary: | REGRESSION(r212768): Rolling out since this would break other projects. (Requested by aakashjain on #webkit). | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | WebKit Commit Bot <commit-queue> | ||||
Component: | New Bugs | Assignee: | WebKit Commit Bot <commit-queue> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | kling, sam | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=168675 | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 168675 | ||||||
Attachments: |
|
Description
WebKit Commit Bot
2017-02-21 17:56:18 PST
Created attachment 302350 [details] ROLLOUT of r212768 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. Attachment 302350 [details] did not pass style-queue:
ERROR: Source/WebKit/ios/Misc/MemoryMeasure.mm:28: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WebKit/ios/Misc/MemoryMeasure.mm:30: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebKit/ios/Misc/MemoryMeasure.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5]
Total errors found: 3 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 302350 [details] ROLLOUT of r212768 Clearing flags on attachment: 302350 Committed r212787: <http://trac.webkit.org/changeset/212787> All reviewed patches have been landed. Closing bug. |