WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
168698
REGRESSION(
r212768
): Rolling out since this would break other projects. (Requested by aakashjain on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=168698
Summary
REGRESSION(r212768): Rolling out since this would break other projects. (Requ...
WebKit Commit Bot
Reported
2017-02-21 17:56:18 PST
http://trac.webkit.org/changeset/212768
broke the build: Rolling out since this would break other projects. (Requested by aakashjain on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail.
Attachments
ROLLOUT of r212768
(17.75 KB, patch)
2017-02-21 17:56 PST
,
WebKit Commit Bot
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
WebKit Commit Bot
Comment 1
2017-02-21 17:56:29 PST
Created
attachment 302350
[details]
ROLLOUT of
r212768
Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
WebKit Commit Bot
Comment 2
2017-02-21 17:59:24 PST
Attachment 302350
[details]
did not pass style-queue: ERROR: Source/WebKit/ios/Misc/MemoryMeasure.mm:28: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/ios/Misc/MemoryMeasure.mm:30: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/ios/Misc/MemoryMeasure.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 3 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3
2017-02-21 18:00:15 PST
Comment on
attachment 302350
[details]
ROLLOUT of
r212768
Clearing flags on attachment: 302350 Committed
r212787
: <
http://trac.webkit.org/changeset/212787
>
WebKit Commit Bot
Comment 4
2017-02-21 18:00:18 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug