Bug 168680

Summary:

[Resource Timing] Media elements initiated loads should set the initiatorType to their element name (video/audio)

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Media

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, jer.noble, joepeck, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[PATCH] Proposed Fix	joepeck: commit-queue-
[PATCH] Proposed Fix	youennf: review+

Joseph Pecoraro

Reported 2017-02-21 15:05:46 PST

[Resource Timing] Media elements initiated loads should set the initiatorType to their element name (video/audio) Media loads should set the CachedResourceRequest with element initiator.

Attachments
[PATCH] Proposed Fix (6.77 KB, patch) 2017-02-21 15:08 PST, Joseph Pecoraro	joepeck: commit-queue-	Details Formatted Diff Diff
[PATCH] Proposed Fix (9.34 KB, patch) 2017-02-21 15:42 PST, Joseph Pecoraro	youennf: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2017-02-21 15:08:05 PST

Created attachment 302318 [details] [PATCH] Proposed Fix

Joseph Pecoraro

Comment 2 2017-02-21 15:22:24 PST

Comment on attachment 302318 [details] [PATCH] Proposed Fix Oo, TestWebKitAPI. On it.

Joseph Pecoraro

Comment 3 2017-02-21 15:42:45 PST

Created attachment 302322 [details] [PATCH] Proposed Fix

youenn fablet

Comment 4 2017-02-24 08:07:23 PST

Comment on attachment 302322 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=302322&action=review > Source/WebCore/loader/MediaResourceLoader.cpp:81 > + cacheRequest.setInitiator(*m_mediaElement.get()); I would remove the use of get(), since it looses RefPtr operator* assert.

Joseph Pecoraro

Comment 5 2017-02-24 23:52:18 PST

<https://trac.webkit.org/changeset/212994>

Note You need to log in before you can comment on or make changes to this bug.