Bug 168679

Summary:

Export various NSString symbols from WebUIDelegatePrivate.h

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

WebKit Misc.

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, commit-queue, joepeck, juergen, mitz

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	none

Aakash Jain

Reported 2017-02-21 14:59:57 PST

There are about 15 symbols which are "extern NSString" in WebUIDelegatePrivate.h. We should export these symbols so that the headers matches with the library.

Attachments
Proposed patch (1.57 KB, patch) 2017-02-21 15:02 PST, Aakash Jain	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2017-02-21 15:02:43 PST

Created attachment 302317 [details] Proposed patch

Joseph Pecoraro

Comment 2 2017-02-21 15:21:38 PST

Comment on attachment 302317 [details] Proposed patch Looks like in source we have WebConsoleMessageContentBlockerMessageSource. Should we create an extern + exp entry for that as well?

Aakash Jain

Comment 3 2017-02-21 15:25:25 PST

Possibly! I think that should be a separate patch.

WebKit Commit Bot

Comment 4 2017-02-21 15:51:28 PST

Comment on attachment 302317 [details] Proposed patch Clearing flags on attachment: 302317 Committed r212774: <http://trac.webkit.org/changeset/212774>

WebKit Commit Bot

Comment 5 2017-02-21 15:51:33 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.