Bug 168673

Summary:

Repatch assembly dump: allow having no CodeBlock

Product:

WebKit

Reporter:

JF Bastien <jfbastien>

Component:

JavaScriptCore

Assignee:

JF Bastien <jfbastien>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, fpizlo, jfbastien, keith_miller, mark.lam, msaboff, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

159775

Attachments:

Description	Flags
patch	fpizlo: review-
patch	fpizlo: review+, jfbastien: commit-queue-
patch	none

JF Bastien

Reported 2017-02-21 14:02:17 PST

Repatch's assembly dump assumes there's a CodeBlock present. WebAssembly doesn't have one. It crashes.

Attachments
patch (3.86 KB, patch) 2017-02-21 14:03 PST, JF Bastien	fpizlo: review-	Details Formatted Diff Diff
patch (17.06 KB, patch) 2017-02-21 16:41 PST, JF Bastien	fpizlo: review+ jfbastien: commit-queue-	Details Formatted Diff Diff
patch (17.05 KB, patch) 2017-02-21 16:48 PST, JF Bastien	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

JF Bastien

Comment 1 2017-02-21 14:03:34 PST

Created attachment 302304 [details] patch

Filip Pizlo

Comment 2 2017-02-21 14:12:06 PST

Comment on attachment 302304 [details] patch I think you should make it easier to say this, since we say it in multiple places. In fact, the usual dumping style for CodeBlock+CodeOrigin is: dataLog(pointerDump(codeBlock), " ", codeOrigin) I think that's what we want here as well. But maybe we can take it a step further and create a helper for it. The right way to go is something like: dataLog(FullCodeOrigin(codeBock, codeOrigin)) Where FullCodeOrigin is a simple value class that holds a CodeBlock* and a CodeOrigin, and has a `void dump(PrintStream&) const` that prints them out.

JF Bastien

Comment 3 2017-02-21 16:41:47 PST

Created attachment 302337 [details] patch Add a helper class as Fil suggested, and use it in a bunch of places. This is nice.

WebKit Commit Bot

Comment 4 2017-02-21 16:42:59 PST

Attachment 302337 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/FullCodeOrigin.h:28: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.

JF Bastien

Comment 5 2017-02-21 16:47:37 PST

Comment on attachment 302337 [details] patch Style fix.

JF Bastien

Comment 6 2017-02-21 16:48:55 PST

Created attachment 302339 [details] patch Fix style.

WebKit Commit Bot

Comment 7 2017-02-21 17:18:28 PST

Comment on attachment 302339 [details] patch Clearing flags on attachment: 302339 Committed r212782: <http://trac.webkit.org/changeset/212782>

WebKit Commit Bot

Comment 8 2017-02-21 17:18:32 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.