Bug 168666

Summary:

[Win] When GraphicsLayerCA::m_uncommittedChanges is initialized with a non-zero value, nothing is painted.

Product:

WebKit

Reporter:

Per Arne Vollan <pvollan>

Component:

WebCore Misc.

Assignee:

Per Arne Vollan <pvollan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bfulgham, buildbot, commit-queue, ddkilzer, mjs, rniwa, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=64808

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
Archive of layout-test-results from ews100 for mac-elcapitan	none
Patch	none

Per Arne Vollan

Reported 2017-02-21 10:57:01 PST

This should be investigated and fixed, also see https://bugs.webkit.org/show_bug.cgi?id=64808.

Attachments
Patch (2.25 KB, patch) 2017-02-22 03:52 PST, Per Arne Vollan	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (841.03 KB, application/zip) 2017-02-22 05:10 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews100 for mac-elcapitan (992.28 KB, application/zip) 2017-02-22 05:47 PST, Build Bot	no flags	Details
Patch (2.25 KB, patch) 2017-02-24 02:13 PST, Per Arne Vollan	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Per Arne Vollan

Comment 1 2017-02-22 03:52:42 PST

Created attachment 302384 [details] Patch

Build Bot

Comment 2 2017-02-22 05:10:32 PST

Comment on attachment 302384 [details] Patch Attachment 302384 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3172192 New failing tests: scrollingcoordinator/ios/non-stable-viewport-scroll.html

Build Bot

Comment 3 2017-02-22 05:10:35 PST

Created attachment 302389 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 4 2017-02-22 05:46:57 PST

Comment on attachment 302384 [details] Patch Attachment 302384 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3172352 New failing tests: editing/spelling/spellcheck-async.html

Build Bot

Comment 5 2017-02-22 05:47:00 PST

Created attachment 302390 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Per Arne Vollan

Comment 6 2017-02-24 02:13:04 PST

Created attachment 302661 [details] Patch

Per Arne Vollan

Comment 7 2017-02-24 02:15:21 PST

(In reply to comment #6) > Created attachment 302661 [details] > Patch Tests failed; uploaded same patch to see if it is consistent.

Maciej Stachowiak

Comment 8 2020-05-30 19:11:28 PDT

Comment on attachment 302661 [details] Patch Seems like a decent cleanup, and shockingly this old patch still applies. r=me

Per Arne Vollan

Comment 9 2020-06-01 06:36:56 PDT

Comment on attachment 302661 [details] Patch Thanks for reviewing!

EWS

Comment 10 2020-06-01 06:56:56 PDT

Committed r262376: <https://trac.webkit.org/changeset/262376> All reviewed patches have been landed. Closing bug and clearing flags on attachment 302661 [details].

Radar WebKit Bug Importer

Comment 11 2020-06-01 06:57:16 PDT

<rdar://problem/63828150>

Note You need to log in before you can comment on or make changes to this bug.