Bug 168641

Summary: Give the Mock audio input a "hum" to make drop-outs more detectable
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: NEW    
Severity: Normal CC: commit-queue, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
eric.carlson: review+
Patch for landing none

Jer Noble
Reported 2017-02-20 23:08:29 PST
Give teh Mock audio input a "hum" to make drop-outs more detectable
Attachments
Patch (7.96 KB, patch)
2017-02-20 23:28 PST, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
Patch for landing (7.97 KB, patch)
2017-02-21 09:40 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2017-02-20 23:28:13 PST
Created attachment 302235 [details] Patch
Jer Noble
Comment 2 2017-02-21 09:40:02 PST
Created attachment 302272 [details] Patch for landing
WebKit Commit Bot
Comment 3 2017-02-21 10:30:32 PST
Comment on attachment 302272 [details] Patch for landing Clearing flags on attachment: 302272 Committed r212725: <http://trac.webkit.org/changeset/212725>
Simon Fraser (smfr)
Comment 4 2017-02-21 17:32:59 PST
Why is there no test, especially when I would expect the Mock Audio Input to affect tests?
Jer Noble
Comment 5 2017-02-21 17:45:39 PST
(In reply to comment #4) > Why is there no test, especially when I would expect the Mock Audio Input to > affect tests? We don't have any way to capture audio data for testing. When we hook up MediaStreams to Web Audio we may eventually have some way of testing this, but that code path isn't implemented yet.
Jer Noble
Comment 6 2017-02-21 17:46:43 PST
(In reply to comment #5) > (In reply to comment #4) > > Why is there no test, especially when I would expect the Mock Audio Input to > > affect tests? > > We don't have any way to capture audio data for testing. When we hook up > MediaStreams to Web Audio we may eventually have some way of testing this, > but that code path isn't implemented yet. And no, this doesn't affect tests, since no test yet depends on the actual /content/ of the audio stream. This change was just for analog/eardrum testing purposes.
Note You need to log in before you can comment on or make changes to this bug.