Bug 168640

Summary:

AudioSampleDataSource doesn't need to use the m_scratchBuffer on the pulling thread

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

New Bugs

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Jer Noble 2017-02-20 23:06:07 PST

AudioSampleDataSource doesn't need to use the m_scratchBuffer on the pulling thread

Comment 1 Jer Noble 2017-02-20 23:07:34 PST

Created attachment 302234 [details]
Patch

Comment 2 Jer Noble 2017-02-21 11:07:19 PST

Created attachment 302286 [details]
Patch

Comment 3 Eric Carlson 2017-02-21 11:48:44 PST

Comment on attachment 302286 [details]
Patch

As we discussed, this isn't correct in the case where the ring buffer data is supposed to be mixed into the output, but the existing code is equally incorrect so I will file a new bug to fix that.

Comment 4 WebKit Commit Bot 2017-02-21 15:20:22 PST

Comment on attachment 302286 [details]
Patch

Clearing flags on attachment: 302286

Committed r212771: <http://trac.webkit.org/changeset/212771>

Comment 5 WebKit Commit Bot 2017-02-21 15:20:26 PST

All reviewed patches have been landed.  Closing bug.