Bug 168638

Summary: Parsing -webkit-hyphenate-character uses confusingly named consumeLocale()
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: TextAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: hyatt, mmaxfield, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch zalan: review+, zalan: commit-queue-

Simon Fraser (smfr)
Reported 2017-02-20 22:53:42 PST
-webkit-hyphenate-character was implemented in http://trac.webkit.org/r61548 parsing as <auto> or a string, but now we just fall through to parsing a locale: CSSPropertyParser.cpp:3761 case CSSPropertyWebkitHyphenateCharacter: case CSSPropertyWebkitLocale: return consumeLocale(m_range);
Attachments
Patch (2.10 KB, patch)
2017-03-07 18:30 PST, Simon Fraser (smfr) 		zalan: review+
zalan: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2017-02-20 22:55:14 PST
https://www.w3.org/TR/css-text-4/#hyphenate-character
Simon Fraser (smfr)
Comment 2 2017-02-21 11:53:43 PST
It's just bad function naming.
Simon Fraser (smfr)
Comment 3 2017-03-07 18:30:58 PST
Created attachment 303756 [details] Patch
zalan
Comment 4 2017-03-07 18:44:52 PST
Comment on attachment 303756 [details] Patch title is misleading.
Simon Fraser (smfr)
Comment 5 2017-03-07 19:15:24 PST
https://trac.webkit.org/r213561
Note You need to log in before you can comment on or make changes to this bug.