Summary: | AudioSampleBufferList::zeroABL() takes a byte-count, not a sample-count. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||
Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ahmad.saleem792, commit-queue, eric.carlson, jeremyj-wk, simon.fraser, webkit-bug-importer, youennf | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Jer Noble
2017-02-20 22:12:49 PST
Created attachment 302232 [details]
Patch
Comment on attachment 302232 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302232&action=review > Source/WebCore/ChangeLog:10 > + (WebCore::AudioSampleDataSource::pullAvalaibleSamplesAsChunks): Weird that it didn't pick up pullSamples instead. And also, terrible spelling of Available. Created attachment 302264 [details]
Patch for landing
(In reply to comment #2) > Comment on attachment 302232 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=302232&action=review > > > Source/WebCore/ChangeLog:10 > > + (WebCore::AudioSampleDataSource::pullAvalaibleSamplesAsChunks): > > Weird that it didn't pick up pullSamples instead. And also, terrible > spelling of Available. Yeah, I think that when a function is too short, the function detector freaks out and picks the previous one. Comment on attachment 302264 [details] Patch for landing Clearing flags on attachment: 302264 Committed r212714: <http://trac.webkit.org/changeset/212714> Why is there no test? Comment on attachment 302264 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=302264&action=review > Source/WebCore/ChangeLog:10 > + (WebCore::AudioSampleDataSource::pullAvalaibleSamplesAsChunks): Speling. (In reply to comment #6) > Why is there no test? We don't have any test infrastructure for inspecting rendered audio. Doesn't web audio have something? https://github.com/WebKit/WebKit/commit/661e7be6621f71f2f55632903c62ad69591dd11d Landed and didn't backed out. Marking this as "RESOLVED FIXED". |