Bug 168635

Summary: AudioSampleBufferList::zeroABL() takes a byte-count, not a sample-count.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: ahmad.saleem792, commit-queue, eric.carlson, jeremyj-wk, simon.fraser, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
jonlee: review+
Patch for landing none

Jer Noble
Reported 2017-02-20 22:12:49 PST
AudioSampleBufferList::zeroABL() takes a byte-count, not a sample-count.
Attachments
Patch (3.75 KB, patch)
2017-02-20 22:33 PST, Jer Noble 		jonlee: review+
DetailsFormatted DiffDiff
Patch for landing (3.73 KB, patch)
2017-02-21 08:34 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2017-02-20 22:33:37 PST
Created attachment 302232 [details] Patch
Jon Lee
Comment 2 2017-02-21 00:22:17 PST
Comment on attachment 302232 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302232&action=review > Source/WebCore/ChangeLog:10 > + (WebCore::AudioSampleDataSource::pullAvalaibleSamplesAsChunks): Weird that it didn't pick up pullSamples instead. And also, terrible spelling of Available.
Jer Noble
Comment 3 2017-02-21 08:34:25 PST
Created attachment 302264 [details] Patch for landing
Jer Noble
Comment 4 2017-02-21 08:56:22 PST
(In reply to comment #2) > Comment on attachment 302232 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=302232&action=review > > > Source/WebCore/ChangeLog:10 > > + (WebCore::AudioSampleDataSource::pullAvalaibleSamplesAsChunks): > > Weird that it didn't pick up pullSamples instead. And also, terrible > spelling of Available. Yeah, I think that when a function is too short, the function detector freaks out and picks the previous one.
WebKit Commit Bot
Comment 5 2017-02-21 09:20:55 PST
Comment on attachment 302264 [details] Patch for landing Clearing flags on attachment: 302264 Committed r212714: <http://trac.webkit.org/changeset/212714>
Simon Fraser (smfr)
Comment 6 2017-02-21 17:34:05 PST
Why is there no test?
Simon Fraser (smfr)
Comment 7 2017-02-21 17:34:38 PST
Comment on attachment 302264 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=302264&action=review > Source/WebCore/ChangeLog:10 > + (WebCore::AudioSampleDataSource::pullAvalaibleSamplesAsChunks): Speling.
Jer Noble
Comment 8 2017-02-21 17:40:19 PST
(In reply to comment #6) > Why is there no test? We don't have any test infrastructure for inspecting rendered audio.
Simon Fraser (smfr)
Comment 9 2017-02-21 18:03:42 PST
Doesn't web audio have something?
Ahmad Saleem
Comment 10 2022-10-10 14:23:45 PDT
https://github.com/WebKit/WebKit/commit/661e7be6621f71f2f55632903c62ad69591dd11d Landed and didn't backed out. Marking this as "RESOLVED FIXED".
Radar WebKit Bug Importer
Comment 11 2022-10-10 14:24:21 PDT
<rdar://problem/100997360>
Note You need to log in before you can comment on or make changes to this bug.