Summary: | Add machine-readable results for bindings tests | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Srinivasan Vijayaraghavan <webkit> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aakash_jain, ap, commit-queue, glenn, jake.nielsen.webkit, lforschler, webkit | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=138235 https://bugs.webkit.org/show_bug.cgi?id=169144 |
||||||||
Attachments: |
|
Description
Srinivasan Vijayaraghavan
2017-02-20 17:38:42 PST
Created attachment 302213 [details]
Patch
Note: webkit-patch upload failed trying to obsolete the attachment on the original bug, so I created a new bug and added the original to the 'See also' field. *** Bug 138235 has been marked as a duplicate of this bug. *** Comment on attachment 302213 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302213&action=review Looks reasonable to me, but I'd like Python experts to take a look too. > Tools/Scripts/webkitpy/bindings/main.py:209 > + 'passes': self.passes, Why is it desirable to add passes to the results too? I don't think that we do it elsewhere. looks good to me, apart from Alexey comment. (In reply to comment #4) > Comment on attachment 302213 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=302213&action=review > > Looks reasonable to me, but I'd like Python experts to take a look too. > > > Tools/Scripts/webkitpy/bindings/main.py:209 > > + 'passes': self.passes, > > Why is it desirable to add passes to the results too? I don't think that we > do it elsewhere. There's no need for it; I'll upload a new patch. Created attachment 302581 [details]
Patch
Comment on attachment 302581 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302581&action=review Looks good overall. Food for thought below. > Tools/Scripts/webkitpy/bindings/main.py:47 > + if self.json_file_name: All of the 'if self.json_file_name' might be a bit pre-mature for optimization. I don't think we will really see a performance hit from always appending errors/failure. The only one conditional I feel should remain is the one that actually does the writing to a file. > Tools/Scripts/webkitpy/bindings/main.py:118 > + if self.json_file_name: Ditto. > Tools/Scripts/webkitpy/bindings/main.py:125 > + if self.json_file_name: Ditto. Comment on attachment 302581 [details]
Patch
I don't have a string opinion on the premature optimization. I agree that this is not necessary for performance, but the code may be easier to read when unnecessary work is not being done.
Comment on attachment 302581 [details] Patch Clearing flags on attachment: 302581 Committed r213097: <http://trac.webkit.org/changeset/213097> All reviewed patches have been landed. Closing bug. |