Bug 168606

Summary: Remove ENABLE_THREADED_COMPOSITOR build option
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, don.olmstead, mcatanzaro
Priority: P2 Keywords: Gtk
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mcatanzaro: review+

Description Carlos Garcia Campos 2017-02-20 10:01:51 PST 
Now that we have AC mode on demand with the threaded compositor there's no reason to keep the old AC code.
Comment 1 Carlos Garcia Campos 2017-02-20 10:05:20 PST 
Created attachment 302154 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-02-20 10:28:38 PST 
Created attachment 302155 [details]
Patch
Comment 3 Michael Catanzaro 2017-02-20 10:32:35 PST 
Comment on attachment 302155 [details]
Patch

Can we remove USE(TEXTURE_MAPPER_GL)?
Comment 4 Michael Catanzaro 2017-02-20 15:06:38 PST 
Note:

 * There are no advantages to disabling threaded compositor.
 * There are two big disadvantages:
   * We never use it or test it.
   * It regularly causes full desktop lockups, bug #126122.

Hence removing it should be uncontroversial.
Comment 5 Carlos Garcia Campos 2017-02-20 22:40:26 PST 
(In reply to comment #3)
> Comment on attachment 302155 [details]
> Patch
> 
> Can we remove USE(TEXTURE_MAPPER_GL)?

Of course not.
Comment 6 Carlos Garcia Campos 2017-02-20 23:14:11 PST 
Committed r212703: <http://trac.webkit.org/changeset/212703>
Comment 7 Michael Catanzaro 2017-02-21 07:49:07 PST 
(In reply to comment #5)
> (In reply to comment #3)
> > Comment on attachment 302155 [details]
> > Patch
> > 
> > Can we remove USE(TEXTURE_MAPPER_GL)?
> 
> Of course not.

It's a shame that there's no documentation for what all these different graphics modes are. ;)
Comment 8 Don Olmstead 2017-02-21 16:55:37 PST 
Carlos this ended up breaking WinCairo. See https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/65682/steps/compile-webkit/logs/stdio for linker errors for TextureMapperTiledBackingStore.
Comment 9 Carlos Garcia Campos 2017-02-21 23:55:05 PST 
(In reply to comment #8)
> Carlos this ended up breaking WinCairo. See
> https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/65682/
> steps/compile-webkit/logs/stdio for linker errors for
> TextureMapperTiledBackingStore.

I'm sorry, I confused TextureMapperBackingStore.cpp with TextureMapperTiledBackingStore.cpp. I'll fix it now.
Comment 10 Carlos Garcia Campos 2017-02-21 23:56:53 PST 
(In reply to comment #9)
> (In reply to comment #8)
> > Carlos this ended up breaking WinCairo. See
> > https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/65682/
> > steps/compile-webkit/logs/stdio for linker errors for
> > TextureMapperTiledBackingStore.
> 
> I'm sorry, I confused TextureMapperBackingStore.cpp with
> TextureMapperTiledBackingStore.cpp. I'll fix it now.

Hopefully fixed in http://trac.webkit.org/changeset/212811
Comment 11 Don Olmstead 2017-02-22 11:23:58 PST 
Back to green! Thanks you