Bug 168585

Summary: BytecodeGenerator should not iterate its m_controlFlowScopeStack using a pointer bump.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, ggaren, jfbastien, keith_miller, msaboff, saam, webkit-bug-importer
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 168580    
Attachments:
Description Flags
proposed patch. ysuzuki: review+

Mark Lam
Reported 2017-02-19 22:46:29 PST
This is because m_controlFlowScopeStack is a SegmentedVector, and entries for consecutive indices in the vector are not guaranteed to be consecutive in memory layout. Instead, we should be using indexing instead.
Attachments
proposed patch. (4.59 KB, patch)
2017-02-19 23:06 PST, Mark Lam 		ysuzuki: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2017-02-19 23:06:21 PST
Created attachment 302118 [details] proposed patch.
Yusuke Suzuki
Comment 2 2017-02-20 00:33:18 PST
Comment on attachment 302118 [details] proposed patch. r=me
Mark Lam
Comment 3 2017-02-20 09:20:57 PST
Thanks for the review. Landed in r212640: <http://trac.webkit.org/r212640>.
Note You need to log in before you can comment on or make changes to this bug.