Bug 168575

Summary: Web Inspector: RTL: adjust positioning of scope bar items with multiple values
Product: WebKit Reporter: BJ Burg <bburg>
Component: Web InspectorAssignee: BJ Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
scope bar - LTR
none
scope bar - RTL
none
Patch none

Description BJ Burg 2017-02-19 08:26:31 PST 
Steps to reproduce:

1. Open Resources Tab
=> Multiple select for Resource Type should have arrows on the trailing edge to hint about multiple options.
=> Clicking on the multiple select should pop up a select menu at approximately where the scope bar item is.
Comment 1 BJ Burg 2017-02-19 13:53:24 PST 
Created attachment 302085 [details]
scope bar - LTR
Comment 2 BJ Burg 2017-02-19 13:53:41 PST 
Created attachment 302086 [details]
scope bar - RTL
Comment 3 BJ Burg 2017-02-19 13:56:29 PST 
Created attachment 302087 [details]
Patch
Comment 4 BJ Burg 2017-02-19 14:56:14 PST 
*** Bug 168286 has been marked as a duplicate of this bug. ***
Comment 5 BJ Burg 2017-02-19 14:56:57 PST 
<rdar://problem/30508109>
Comment 6 Matt Baker 2017-02-20 10:50:36 PST 
Comment on attachment 302087 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302087&action=review

> Source/WebInspectorUI/UserInterface/Views/ScopeBar.css:60
> +body[dir=ltr] .scope-bar > li.multiple > select {

I had to compare the new and old <select> popovers in Photoshop to tell the difference. Nice touch. It looks like we could get a few pixels closer still (on retina at least) but I don't think it matters.
Comment 7 Matt Baker 2017-02-20 10:50:56 PST 
Comment on attachment 302087 [details]
Patch

r=me
Comment 8 WebKit Commit Bot 2017-02-20 11:16:36 PST 
Comment on attachment 302087 [details]
Patch

Clearing flags on attachment: 302087

Committed r212662: <http://trac.webkit.org/changeset/212662>
Comment 9 WebKit Commit Bot 2017-02-20 11:16:41 PST 
All reviewed patches have been landed.  Closing bug.