Bug 168574

Summary: functionTestWasmModuleFunctions() should use a MarkedArgumentBuffer for storing args instead of a Vector.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, ggaren, jfbastien, keith_miller, msaboff, saam
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. fpizlo: review+

Mark Lam
Reported 2017-02-19 08:17:40 PST
Vectors don't tell GC about the need to scan the args.
Attachments
proposed patch. (3.35 KB, patch)
2017-02-19 19:53 PST, Mark Lam 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
JF Bastien
Comment 1 2017-02-19 13:44:23 PST
I think we're better off getting rid of the function entirely, now that we have the JS builder.
Mark Lam
Comment 2 2017-02-19 13:54:12 PST
(In reply to comment #1) > I think we're better off getting rid of the function entirely, now that we > have the JS builder. Is functionTestWasmModuleFunctions() no longer needed?
JF Bastien
Comment 3 2017-02-19 13:56:07 PST
(In reply to comment #2) > (In reply to comment #1) > > I think we're better off getting rid of the function entirely, now that we > > have the JS builder. > > Is functionTestWasmModuleFunctions() no longer needed? IIRC we need to update some tests to use the JS builder instead of that function. It's still needed until we update the tests.
Mark Lam
Comment 4 2017-02-19 19:53:45 PST
Created attachment 302114 [details] proposed patch.
Mark Lam
Comment 5 2017-02-19 20:02:18 PST
Thanks for the review. Landed in r212620: <http://trac.webkit.org/r212620>.
Keith Miller
Comment 6 2017-02-20 09:27:34 PST
Yeah, I'm pretty sure we don't have tests that use this function anymore. Also, as a note, we don't really need to use a MarkedArgumentBuffer since we can't put JSCells into that vector so the GC won't see anything of interest anyway. The only reason the contents of that vector were JSValues is to avoid casting when we did vmEntryToJavaScript.
Note You need to log in before you can comment on or make changes to this bug.