Bug 168543

Summary: [SOUP] Add support for "nextHopProtocol" for Resource Timing
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, bugs-noreply, cgarcia, joepeck, lmoura, mcatanzaro
Priority: P2 Keywords: Gtk, LayoutTestFailure
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 168351    
Bug Blocks:    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch aperez: review+

Joseph Pecoraro
Reported 2017-02-17 17:36:41 PST
[GTK] Add support for "nextHopProtocol" for Resource Timing Spec: https://w3c.github.io/resource-timing/#dom-performanceresourcetiming-nexthopprotocol Tests: imported/w3c/web-platform-tests/resource-timing/rt-nextHopProtocol.html Related: Bug 168351
Attachments
Patch (3.70 KB, patch)
2021-04-14 05:08 PDT, Carlos Garcia Campos 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (3.06 KB, patch)
2021-04-14 05:18 PDT, Carlos Garcia Campos 		aperez: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Lauro Moura
Comment 1 2020-07-07 20:37:48 PDT
The WPT resync for service worker tests in r264043 added another test depending on nextHopProtocol: imported/w3c/web-platform-tests/service-workers/service-worker/next-hop-protocol.https.html. Gardened it with the other two tests in r264057.
Lauro Moura
Comment 2 2020-07-16 20:57:56 PDT
(In reply to Lauro Moura from comment #1) > The WPT resync for service worker tests in r264043 added another test > depending on nextHopProtocol: > imported/w3c/web-platform-tests/service-workers/service-worker/next-hop- > protocol.https.html. Gardened it with the other two tests in r264057. Ditto for imported/w3c/web-platform-tests/resource-timing/nextHopProtocol-tao-protected.https.html from r264458.
Carlos Garcia Campos
Comment 3 2021-04-14 05:05:22 PDT
*** Bug 222558 has been marked as a duplicate of this bug. ***
Carlos Garcia Campos
Comment 4 2021-04-14 05:08:57 PDT
Created attachment 425971 [details] Patch
Carlos Garcia Campos
Comment 5 2021-04-14 05:18:38 PDT
Created attachment 425972 [details] Patch
Michael Catanzaro
Comment 6 2021-04-14 08:51:30 PDT
Comment on attachment 425972 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425972&action=review Thank you! > Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:1005 > + m_networkLoadMetrics.protocol = soup_message_get_http_version(m_soupMessage.get()) == SOUP_HTTP_1_0 ? "http/1.0" : "http/1.1"; Are libsoup3 and HTTP/2 covered elsewhere?
Carlos Garcia Campos
Comment 7 2021-04-15 01:08:23 PDT
(In reply to Michael Catanzaro from comment #6) > Comment on attachment 425972 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=425972&action=review > > Thank you! > > > Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:1005 > > + m_networkLoadMetrics.protocol = soup_message_get_http_version(m_soupMessage.get()) == SOUP_HTTP_1_0 ? "http/1.0" : "http/1.1"; > > Are libsoup3 and HTTP/2 covered elsewhere? Not yet.
Carlos Garcia Campos
Comment 8 2021-04-15 01:34:48 PDT
Committed r276009 (236561@main): <https://commits.webkit.org/236561@main>
Joseph Pecoraro
Comment 9 2021-04-26 12:34:18 PDT
Comment on attachment 425972 [details] Patch Nice!
Note You need to log in before you can comment on or make changes to this bug.