| Summary: | [Modern Media Controls] Clicking on the tracks button when the tracks panel is up in a media document pauses the video | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||||||||||||||||||
| Component: | Media | Assignee: | Antoine Quint <graouts> | ||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||
| Severity: | Normal | CC: | buildbot, dino, eric.carlson, rniwa, webkit-bug-importer | ||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||
|
Description
Antoine Quint
2017-02-17 08:12:02 PST
Created attachment 305467 [details]
Patch
Comment on attachment 305467 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305467&action=review > Source/WebCore/html/MediaDocument.cpp:197 > + // pause or Nit: "when to pause or ..." Comment on attachment 305467 [details] Patch Attachment 305467 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3418212 New failing tests: media/video-click-dblckick-standalone.html media/modern-media-controls/media-documents/media-documents-dismissing-tracks-panel-by-tapping-on-tracks-button-should-not-pause.html Created attachment 305472 [details]
Archive of layout-test-results from ews100 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 305473 [details]
Patch
Created attachment 305474 [details]
Patch
Comment on attachment 305474 [details] Patch Attachment 305474 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3418388 New failing tests: media/modern-media-controls/media-documents/media-documents-dismissing-tracks-panel-by-tapping-on-tracks-button-should-not-pause.html Created attachment 305476 [details]
Archive of layout-test-results from ews100 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 305474 [details] Patch Attachment 305474 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3418423 New failing tests: media/modern-media-controls/media-documents/media-documents-dismissing-tracks-panel-by-tapping-on-tracks-button-should-not-pause.html Created attachment 305478 [details]
Archive of layout-test-results from ews114 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 305474 [details] Patch Attachment 305474 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3418467 New failing tests: media/modern-media-controls/media-documents/media-documents-dismissing-tracks-panel-by-tapping-on-tracks-button-should-not-pause.html Created attachment 305482 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Created attachment 305483 [details]
Patch
Comment on attachment 305483 [details] Patch Attachment 305483 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3418798 New failing tests: media/modern-media-controls/media-documents/media-documents-dismissing-tracks-panel-by-tapping-on-tracks-button-should-not-pause.html Created attachment 305490 [details]
Archive of layout-test-results from ews103 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Committed r214426: <http://trac.webkit.org/changeset/214426> |