RESOLVED FIXED Bug 168517
[Modern Media Controls] Clicking on the tracks button when the tracks panel is up in a media document pauses the video 
https://bugs.webkit.org/show_bug.cgi?id=168517
Summary [Modern Media Controls] Clicking on the tracks button when the tracks panel i...
Antoine Quint
Reported 2017-02-17 08:12:02 PST
Clicking on the tracks button when the tracks panel is up in a media document pauses the video. For some reason we don't see the "click" event on the container and cannot call "event.preventDefault()" to override the built-in behaviour that toggles playback when clicking on the video frame.
Attachments
Patch (9.73 KB, patch)
2017-03-27 08:05 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews100 for mac-elcapitan (911.06 KB, application/zip)
2017-03-27 09:13 PDT, Build Bot 		no flags
Details
Patch (10.36 KB, patch)
2017-03-27 09:15 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (10.38 KB, patch)
2017-03-27 09:17 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews100 for mac-elcapitan (1.09 MB, application/zip)
2017-03-27 10:01 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews114 for mac-elcapitan (1.81 MB, application/zip)
2017-03-27 10:23 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (930.87 KB, application/zip)
2017-03-27 10:32 PDT, Build Bot 		no flags
Details
Patch (10.43 KB, patch)
2017-03-27 10:36 PDT, Antoine Quint 		dino: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-elcapitan (907.77 KB, application/zip)
2017-03-27 11:43 PDT, Build Bot 		no flags
Details
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-02-17 08:14:55 PST
<rdar://problem/30577636>
Antoine Quint
Comment 2 2017-03-27 08:05:43 PDT
Created attachment 305467 [details] Patch
Eric Carlson
Comment 3 2017-03-27 08:11:05 PDT
Comment on attachment 305467 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305467&action=review > Source/WebCore/html/MediaDocument.cpp:197 > + // pause or Nit: "when to pause or ..."
Build Bot
Comment 4 2017-03-27 09:13:06 PDT
Comment on attachment 305467 [details] Patch Attachment 305467 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3418212 New failing tests: media/video-click-dblckick-standalone.html media/modern-media-controls/media-documents/media-documents-dismissing-tracks-panel-by-tapping-on-tracks-button-should-not-pause.html
Build Bot
Comment 5 2017-03-27 09:13:08 PDT
Created attachment 305472 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Antoine Quint
Comment 6 2017-03-27 09:15:24 PDT
Created attachment 305473 [details] Patch
Antoine Quint
Comment 7 2017-03-27 09:17:24 PDT
Created attachment 305474 [details] Patch
Build Bot
Comment 8 2017-03-27 10:01:03 PDT
Comment on attachment 305474 [details] Patch Attachment 305474 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3418388 New failing tests: media/modern-media-controls/media-documents/media-documents-dismissing-tracks-panel-by-tapping-on-tracks-button-should-not-pause.html
Build Bot
Comment 9 2017-03-27 10:01:06 PDT
Created attachment 305476 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 10 2017-03-27 10:23:01 PDT
Comment on attachment 305474 [details] Patch Attachment 305474 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3418423 New failing tests: media/modern-media-controls/media-documents/media-documents-dismissing-tracks-panel-by-tapping-on-tracks-button-should-not-pause.html
Build Bot
Comment 11 2017-03-27 10:23:03 PDT
Created attachment 305478 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 12 2017-03-27 10:32:25 PDT
Comment on attachment 305474 [details] Patch Attachment 305474 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3418467 New failing tests: media/modern-media-controls/media-documents/media-documents-dismissing-tracks-panel-by-tapping-on-tracks-button-should-not-pause.html
Build Bot
Comment 13 2017-03-27 10:32:27 PDT
Created attachment 305482 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Antoine Quint
Comment 14 2017-03-27 10:36:00 PDT
Created attachment 305483 [details] Patch
Build Bot
Comment 15 2017-03-27 11:43:09 PDT
Comment on attachment 305483 [details] Patch Attachment 305483 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3418798 New failing tests: media/modern-media-controls/media-documents/media-documents-dismissing-tracks-panel-by-tapping-on-tracks-button-should-not-pause.html
Build Bot
Comment 16 2017-03-27 11:43:12 PDT
Created attachment 305490 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Antoine Quint
Comment 17 2017-03-27 12:44:18 PDT
Committed r214426: <http://trac.webkit.org/changeset/214426>
Note You need to log in before you can comment on or make changes to this bug.