Bug 168517 - [Modern Media Controls] Clicking on the tracks button when the tracks panel is up in a media document pauses the video
Summary: [Modern Media Controls] Clicking on the tracks button when the tracks panel i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-17 08:12 PST by Antoine Quint
Modified: 2017-03-27 12:44 PDT (History)
5 users (show)

See Also:


Attachments
Patch (9.73 KB, patch)
2017-03-27 08:05 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-elcapitan (911.06 KB, application/zip)
2017-03-27 09:13 PDT, Build Bot
no flags Details
Patch (10.36 KB, patch)
2017-03-27 09:15 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch (10.38 KB, patch)
2017-03-27 09:17 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-elcapitan (1.09 MB, application/zip)
2017-03-27 10:01 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews114 for mac-elcapitan (1.81 MB, application/zip)
2017-03-27 10:23 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (930.87 KB, application/zip)
2017-03-27 10:32 PDT, Build Bot
no flags Details
Patch (10.43 KB, patch)
2017-03-27 10:36 PDT, Antoine Quint
dino: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-elcapitan (907.77 KB, application/zip)
2017-03-27 11:43 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2017-02-17 08:12:02 PST
Clicking on the tracks button when the tracks panel is up in a media document pauses the video. For some reason we don't see the "click" event on the container and cannot call "event.preventDefault()" to override the built-in behaviour that toggles playback when clicking on the video frame.
Comment 1 Radar WebKit Bug Importer 2017-02-17 08:14:55 PST
<rdar://problem/30577636>
Comment 2 Antoine Quint 2017-03-27 08:05:43 PDT
Created attachment 305467 [details]
Patch
Comment 3 Eric Carlson 2017-03-27 08:11:05 PDT
Comment on attachment 305467 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305467&action=review

> Source/WebCore/html/MediaDocument.cpp:197
> +    // pause or 

Nit: "when to pause or ..."
Comment 4 Build Bot 2017-03-27 09:13:06 PDT
Comment on attachment 305467 [details]
Patch

Attachment 305467 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3418212

New failing tests:
media/video-click-dblckick-standalone.html
media/modern-media-controls/media-documents/media-documents-dismissing-tracks-panel-by-tapping-on-tracks-button-should-not-pause.html
Comment 5 Build Bot 2017-03-27 09:13:08 PDT
Created attachment 305472 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 Antoine Quint 2017-03-27 09:15:24 PDT
Created attachment 305473 [details]
Patch
Comment 7 Antoine Quint 2017-03-27 09:17:24 PDT
Created attachment 305474 [details]
Patch
Comment 8 Build Bot 2017-03-27 10:01:03 PDT
Comment on attachment 305474 [details]
Patch

Attachment 305474 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3418388

New failing tests:
media/modern-media-controls/media-documents/media-documents-dismissing-tracks-panel-by-tapping-on-tracks-button-should-not-pause.html
Comment 9 Build Bot 2017-03-27 10:01:06 PDT
Created attachment 305476 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 10 Build Bot 2017-03-27 10:23:01 PDT
Comment on attachment 305474 [details]
Patch

Attachment 305474 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3418423

New failing tests:
media/modern-media-controls/media-documents/media-documents-dismissing-tracks-panel-by-tapping-on-tracks-button-should-not-pause.html
Comment 11 Build Bot 2017-03-27 10:23:03 PDT
Created attachment 305478 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 12 Build Bot 2017-03-27 10:32:25 PDT
Comment on attachment 305474 [details]
Patch

Attachment 305474 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3418467

New failing tests:
media/modern-media-controls/media-documents/media-documents-dismissing-tracks-panel-by-tapping-on-tracks-button-should-not-pause.html
Comment 13 Build Bot 2017-03-27 10:32:27 PDT
Created attachment 305482 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 14 Antoine Quint 2017-03-27 10:36:00 PDT
Created attachment 305483 [details]
Patch
Comment 15 Build Bot 2017-03-27 11:43:09 PDT
Comment on attachment 305483 [details]
Patch

Attachment 305483 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3418798

New failing tests:
media/modern-media-controls/media-documents/media-documents-dismissing-tracks-panel-by-tapping-on-tracks-button-should-not-pause.html
Comment 16 Build Bot 2017-03-27 11:43:12 PDT
Created attachment 305490 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 17 Antoine Quint 2017-03-27 12:44:18 PDT
Committed r214426: <http://trac.webkit.org/changeset/214426>