Bug 168511

Summary: Remove EFL from WebKit2
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKit2Assignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, andersca, bugs-noreply, cgarcia, commit-queue, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch none

Michael Catanzaro
Reported 2017-02-17 06:39:04 PST
Remove EFL from WebKit2
Attachments
Patch (63.64 KB, patch)
2017-02-17 06:41 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Patch (63.67 KB, patch)
2017-02-17 07:21 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2017-02-17 06:41:03 PST
Created attachment 301921 [details] Patch
Michael Catanzaro
Comment 2 2017-02-17 07:21:27 PST
Created attachment 301930 [details] Patch
Alex Christensen
Comment 3 2017-02-17 10:46:26 PST
Comment on attachment 301930 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301930&action=review Thanks! > Source/WebKit2/UIProcess/CoordinatedGraphics/PageViewportController.cpp:87 > FloatPoint PageViewportController::pixelAlignedFloatPoint(const FloatPoint& framePosition) This could probably be further simplified.
WebKit Commit Bot
Comment 4 2017-02-17 11:12:21 PST
Comment on attachment 301930 [details] Patch Clearing flags on attachment: 301930 Committed r212557: <http://trac.webkit.org/changeset/212557>
WebKit Commit Bot
Comment 5 2017-02-17 11:12:26 PST
All reviewed patches have been landed. Closing bug.
Michael Catanzaro
Comment 6 2017-02-17 11:47:05 PST
(In reply to comment #3) > > Source/WebKit2/UIProcess/CoordinatedGraphics/PageViewportController.cpp:87 > > FloatPoint PageViewportController::pixelAlignedFloatPoint(const FloatPoint& framePosition) > > This could probably be further simplified. Good point, considering the function is a no-op now. Some of the uses of it are not trivial though, e.g. there is the comment "The scale changed, we have to re-pixel align." So it'd be good if someone with graphics expertise could look into this.
Note You need to log in before you can comment on or make changes to this bug.