Bug 168509

Summary: [SOUP] Stop removing the fragment identifier from resource requests
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, commit-queue, danw, gustavo, mcatanzaro, mrobinson, svillar
Priority: P2 Keywords: Gtk, LayoutTestFailure
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch svillar: review+

Carlos Garcia Campos
Reported 2017-02-17 06:09:52 PST
I don't know why, but have always removed the fragment identifiers from the URL when creating the SoupURI that is passed to libsoup. Maybe it was a bug in a very old version of libsoup, but it doesn't look necessary anymore and it's causing several layout tests failures.
Attachments
Patch (2.41 KB, patch)
2017-02-17 06:12 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch (2.41 KB, patch)
2017-02-17 06:13 PST, Carlos Garcia Campos 		svillar: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-02-17 06:12:25 PST
Created attachment 301918 [details] Patch
Carlos Garcia Campos
Comment 2 2017-02-17 06:13:38 PST
Created attachment 301919 [details] Patch
Carlos Garcia Campos
Comment 3 2017-02-17 06:48:26 PST
Committed r212548: <http://trac.webkit.org/changeset/212548>
Martin Robinson
Comment 4 2017-02-17 06:50:14 PST
Out of curiosity I tracked down this behavior to: https://trac.webkit.org/changeset/41058 Here's the original comment: // GIO doesn't know how to handle refs and queries, so remove them // TODO: use KURL.fileSystemPath after KURLGtk and FileSystemGtk are // using GIO internally, and providing URIs instead of file paths
Martin Robinson
Comment 5 2017-02-17 06:51:29 PST
The origin of the behavior is here: https://trac.webkit.org/changeset/33594
Carlos Garcia Campos
Comment 6 2017-02-17 06:55:23 PST
(In reply to comment #4) > Out of curiosity I tracked down this behavior to: > https://trac.webkit.org/changeset/41058 > > Here's the original comment: > // GIO doesn't know how to handle refs and queries, so remove them > // TODO: use KURL.fileSystemPath after KURLGtk and FileSystemGtk are > // using GIO internally, and providing URIs instead of file paths But I think this was only done for local files. This code was removed actually. For URLS we have always done it.
Michael Catanzaro
Comment 7 2017-02-17 07:17:05 PST
So this is why anchor links have always been buggy for us...? WTF. :(
Note You need to log in before you can comment on or make changes to this bug.