Bug 168497

Summary:

Web Inspector: RTL: Settings tab labels need adjustment

Product:

WebKit

Reporter:

Matt Baker <mattbaker>

Component:

Web Inspector

Assignee:

Blaze Burg <bburg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, inspector-bugzilla-changes

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Image] Settings tab w/ RTL layout	none
Patch	none
Settings Tab (RTL)	none

Matt Baker

Reported 2017-02-16 22:58:29 PST

Created attachment 301886 [details] [Image] Settings tab w/ RTL layout Labels should be left aligned now that they're in the rightmost column.

Attachments
[Image] Settings tab w/ RTL layout (223.69 KB, image/png) 2017-02-16 22:58 PST, Matt Baker	no flags	Details
Patch (4.10 KB, patch) 2017-02-22 07:15 PST, Blaze Burg	no flags	Details Formatted Diff Diff
Settings Tab (RTL) (119.80 KB, image/png) 2017-02-22 07:15 PST, Blaze Burg	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Blaze Burg

Comment 1 2017-02-22 07:15:26 PST

Created attachment 302400 [details] Patch

Blaze Burg

Comment 2 2017-02-22 07:15:55 PST

Created attachment 302401 [details] Settings Tab (RTL)

Blaze Burg

Comment 3 2017-02-22 07:16:59 PST

Comment on attachment 302401 [details] Settings Tab (RTL) Note that the string parentheses bug in the Layout Direction select is a WebCore text rendering bug, per Myles.

Matt Baker

Comment 4 2017-02-22 09:31:11 PST

Comment on attachment 302400 [details] Patch r=me

WebKit Commit Bot

Comment 5 2017-02-22 09:58:38 PST

Comment on attachment 302400 [details] Patch Clearing flags on attachment: 302400 Committed r212838: <http://trac.webkit.org/changeset/212838>

WebKit Commit Bot

Comment 6 2017-02-22 09:58:42 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.