Bug 168492

Summary: Use expect.js instead of expect in browser tests
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Perf DashboardAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, joepeck, rniwa
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Replaces the library joepeck: review+

Ryosuke Niwa
Reported 2017-02-16 19:54:09 PST
The perf dashboard's browser tests should be using expect.js, not expect.
Attachments
Replaces the library (32.36 KB, patch)
2017-02-16 19:59 PST, Ryosuke Niwa 		joepeck: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2017-02-16 19:59:05 PST
Created attachment 301872 [details] Replaces the library
Joseph Pecoraro
Comment 2 2017-02-16 20:02:57 PST
Comment on attachment 301872 [details] Replaces the library View in context: https://bugs.webkit.org/attachment.cgi?id=301872&action=review rs=me > Websites/perf.webkit.org/browser-tests/editable-text-tests.js:80 > + return waitCopmonentToRender(context); Typo: "Copmonent" => "Component" Maybe instead of "waitComponentToRender" this should be "waitForComponentToRender" ?
Ryosuke Niwa
Comment 3 2017-02-16 21:35:34 PST
Actually, they should be waitForComponentsToRender since it waits for all components that got enqueued to render instead of just a specific component to render. Thanks for the review!
Ryosuke Niwa
Comment 4 2017-02-16 21:37:46 PST
Committed r212533: <http://trac.webkit.org/changeset/212533>
Note You need to log in before you can comment on or make changes to this bug.