Bug 168484

Summary: Modernize and fix measurement-set tests
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Perf DashboardAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, rniwa
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch joepeck: review+

Ryosuke Niwa
Reported 2017-02-16 17:08:23 PST
New version of node which reports unhandled promises found a bunch of bugs in measurement-set-tests.js. Fix the tests and also fix a tiny bug in hasFetchedRange I found by fixing the tests.
Attachments
Patch (42.19 KB, patch)
2017-02-16 17:27 PST, Ryosuke Niwa 		joepeck: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2017-02-16 17:27:04 PST
Created attachment 301865 [details] Patch
Joseph Pecoraro
Comment 2 2017-02-16 19:46:41 PST
Comment on attachment 301865 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301865&action=review r=me > Websites/perf.webkit.org/unit-tests/measurement-set-tests.js:114 > + it('should invoke the callback and fetch a secondary cluster when the cached primary cluster is within in the requested range', () => { Typo: "is within in" => "is within"
Ryosuke Niwa
Comment 3 2017-02-16 19:51:51 PST
Committed r212520: <http://trac.webkit.org/changeset/212520>
Note You need to log in before you can comment on or make changes to this bug.