Bug 168456

Summary: Remove unused method WKBundlePageCopyContextMenuItemTitle
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: WebKit2Assignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, juergen, mitz
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
mitz: review+, buildbot: commit-queue-
Archive of layout-test-results from ews112 for mac-elcapitan
none
Updated patch none

Aakash Jain
Reported 2017-02-16 12:58:49 PST
WKBundlePageCopyContextMenuItemTitle method declaration in WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h is unused. It doesn't have corresponding definition. Seems like it was added by mistake in https://bugs.webkit.org/show_bug.cgi?id=98410
Attachments
Proposed patch (2.18 KB, patch)
2017-02-16 13:05 PST, Aakash Jain 		mitz: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews112 for mac-elcapitan (1.51 MB, application/zip)
2017-02-16 14:37 PST, Build Bot 		no flags
Details
Updated patch (1.48 KB, patch)
2017-02-16 14:49 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2017-02-16 13:05:22 PST
Created attachment 301806 [details] Proposed patch
Build Bot
Comment 2 2017-02-16 14:37:47 PST
Comment on attachment 301806 [details] Proposed patch Attachment 301806 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3134949 New failing tests: imported/w3c/web-platform-tests/resource-timing/rt-resource-ignored.html
Build Bot
Comment 3 2017-02-16 14:37:50 PST
Created attachment 301827 [details] Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Aakash Jain
Comment 4 2017-02-16 14:49:30 PST
Created attachment 301829 [details] Updated patch
WebKit Commit Bot
Comment 5 2017-02-16 15:28:35 PST
Comment on attachment 301829 [details] Updated patch Clearing flags on attachment: 301829 Committed r212475: <http://trac.webkit.org/changeset/212475>
WebKit Commit Bot
Comment 6 2017-02-16 15:28:38 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.