Bug 168433

Summary: [GTK] Lack of support for CrossOriginPreflight XHR request
Product: WebKit Reporter: Javier Fernandez <jfernandez>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: bugs-noreply, crzwdjk, jfernandez, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Current diff of the test failure. none

Description Javier Fernandez 2017-02-16 07:11:39 PST
The change in r204795 added support on WebCore for redirect post CORS-preflight requests.
This enabled to follow cross-origin redirections for not-simple requests, through preflight checks.

We were not processing the non-simple request on http/tests/xmlhttprequest/redirections-and-user-headers.html fails because of this, but now they are being processed.

I don t think such test fails because of that, but it definitively triggered some missing features of the GTK port.
Comment 1 Javier Fernandez 2017-02-16 07:12:28 PST
Please, Youenn, if you have time take a look.
Comment 2 youenn fablet 2017-02-16 08:19:30 PST
This code should be cross-platform but hey, we never know!
Looking at the current GTK result, it does not seem related to CORS/preflight since one same-origin redirection test is not passing either (Authentication header present).

Is r204795 regressing the test in GTK?
Comment 3 Javier Fernandez 2017-02-16 08:39:03 PST
(In reply to comment #2)
> This code should be cross-platform but hey, we never know!
> Looking at the current GTK result, it does not seem related to
> CORS/preflight since one same-origin redirection test is not passing either
> (Authentication header present).
> 
> Is r204795 regressing the test in GTK?

Not exactly. The test was already failing before r204795 but with a different error. I think the new errors come from the fact that after r204795 we allow  same-origin redirections for non-simple requests. 

My request for review would be more to get some clue about what webkitgtk could be missing to cause the current failure of this test.
Comment 4 Javier Fernandez 2017-02-16 08:43:00 PST
Created attachment 301771 [details]
Current diff of the test failure.
Comment 5 Arcady Goldmints-Orlov 2021-11-19 14:31:48 PST
This appears to have been fixed under 230935.

*** This bug has been marked as a duplicate of bug 230935 ***