Bug 168408

Summary:

Refactor AccessCase to be more like B3Value

Product:

WebKit

Reporter:

Keith Miller <keith_miller>

Component:

New Bugs

Assignee:

Keith Miller <keith_miller>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, mark.lam, msaboff, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch for landing	none

Keith Miller

Reported 2017-02-15 20:41:23 PST

Refactor AccessCase to be more like B3Value

Attachments
Patch (173.94 KB, patch) 2017-02-15 21:06 PST, Keith Miller	no flags	Details Formatted Diff Diff
Patch (173.99 KB, patch) 2017-02-16 09:28 PST, Keith Miller	no flags	Details Formatted Diff Diff
Patch (185.91 KB, patch) 2017-02-16 09:57 PST, Keith Miller	no flags	Details Formatted Diff Diff
Patch for landing (185.99 KB, patch) 2017-02-16 10:19 PST, Keith Miller	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Keith Miller

Comment 1 2017-02-15 21:06:23 PST

Created attachment 301700 [details] Patch

Keith Miller

Comment 2 2017-02-16 09:28:06 PST

Created attachment 301775 [details] Patch

WebKit Commit Bot

Comment 3 2017-02-16 09:31:11 PST

Attachment 301775 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/AccessCase.h:47: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/bytecode/AccessCase.h:55: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/bytecode/AccessCase.h:64: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 3 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.

Filip Pizlo

Comment 4 2017-02-16 09:36:30 PST

Comment on attachment 301775 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301775&action=review > Source/JavaScriptCore/bytecode/AccessCase.cpp:160 > +IntrinsicGetterAccessCase::~IntrinsicGetterAccessCase() Can we put these in separate files named after the class?

Keith Miller

Comment 5 2017-02-16 09:57:47 PST

Created attachment 301776 [details] Patch

Keith Miller

Comment 6 2017-02-16 09:58:49 PST

(In reply to comment #4) > Comment on attachment 301775 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=301775&action=review > > > Source/JavaScriptCore/bytecode/AccessCase.cpp:160 > > +IntrinsicGetterAccessCase::~IntrinsicGetterAccessCase() > > Can we put these in separate files named after the class? done.

Keith Miller

Comment 7 2017-02-16 10:19:24 PST

Created attachment 301779 [details] Patch for landing

WebKit Commit Bot

Comment 8 2017-02-16 10:21:02 PST

Attachment 301779 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/AccessCase.h:47: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/bytecode/AccessCase.h:55: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/bytecode/AccessCase.h:64: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 3 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.

Keith Miller

Comment 9 2017-02-16 11:46:37 PST

Committed r212453: <http://trac.webkit.org/changeset/212453>

Note You need to log in before you can comment on or make changes to this bug.