Summary: | JSC: fix compilation errors for MIPS | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Guillaume Emont <guijemont> | ||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | annulen, commit-queue, jbriance, keith_miller, mark.lam, msaboff, saam | ||||
Priority: | P2 | ||||||
Version: | Other | ||||||
Hardware: | Other | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Guillaume Emont
2017-02-15 18:38:32 PST
Created attachment 301689 [details]
Patch
Patch by Suresh Kumar with small modifications by myself.
(In reply to comment #1) > Created attachment 301689 [details] > Patch > > Patch by Suresh Kumar with small modifications by myself. Note that there is a style error in the order of includes in MacroAssemblerMIPS.h. I don't know how to solve it since compilation fails if the includes are in the opposite order. I imagine this means we miss an include somewhere, but I could not find which one so far. Attachment 301689 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:32: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > Note that there is a style error in the order of includes in > MacroAssemblerMIPS.h. I don't know how to solve it since compilation fails > if the includes are in the opposite order. I imagine this means we miss an > include somewhere, but I could not find which one so far. Note that MacroAssemblerX86Common.h has the same non-alphabetical order of includes. Just fount that the header issue is due to AbstractMacroAssembler.h not including wtf/Vector.h, which means in some cases its use of Vector ends up using the template in wtf/Forward.h which requires 4 arguments. Will send a patch for that later tonight or tomorrow. I proposed a patch for the header issue in https://bugs.webkit.org/show_bug.cgi?id=168537 but it seems to create compilation issues on Mac so I think I need to examine that further. After further investigation, I don't think there is an easy fix for the header issue. Can this patch be accepted despite this issue? Comment on attachment 301689 [details]
Patch
rs=me
Comment on attachment 301689 [details] Patch Clearing flags on attachment: 301689 Committed r213881: <http://trac.webkit.org/changeset/213881> All reviewed patches have been landed. Closing bug. |