Bug 168395

Summary:

[MediaStream] delete CaptureDeviceInfo struct

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

ASSIGNED ---

Severity:

Normal

CC:

commit-queue, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	sam: review+
Patch for landing.	none

Description Eric Carlson 2017-02-15 15:06:42 PST

Use the existing CaptureDevice class.

Comment 1 Radar WebKit Bug Importer 2017-02-15 15:09:38 PST

<rdar://problem/30544426>

Comment 2 Eric Carlson 2017-02-15 15:23:58 PST

Created attachment 301663 [details]
Proposed patch

Comment 3 Sam Weinig 2017-02-15 16:01:59 PST

Comment on attachment 301663 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301663&action=review

> Source/WebCore/ChangeLog:11
> +        No new tests, no behavior change.
> +
> +        * Modules/mediastream/MediaDevicesRequest.cpp:
> +        (WebCore::MediaDevicesRequest::start):

ChangeLog could use more information, since you are doing more than just deleting a struct.

Comment 4 Eric Carlson 2017-02-15 16:39:21 PST

Created attachment 301672 [details]
Patch for landing.

Comment 5 WebKit Commit Bot 2017-02-15 18:03:39 PST

Comment on attachment 301672 [details]
Patch for landing.

Clearing flags on attachment: 301672

Committed r212418: <http://trac.webkit.org/changeset/212418>