Bug 168395

Summary: [MediaStream] delete CaptureDeviceInfo struct
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: ASSIGNED    
Severity: Normal CC: commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
sam: review+
Patch for landing. none

Eric Carlson
Reported 2017-02-15 15:06:42 PST
Use the existing CaptureDevice class.
Attachments
Proposed patch (20.46 KB, patch)
2017-02-15 15:23 PST, Eric Carlson 		sam: review+
DetailsFormatted DiffDiff
Patch for landing. (20.88 KB, patch)
2017-02-15 16:39 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-02-15 15:09:38 PST
<rdar://problem/30544426>
Eric Carlson
Comment 2 2017-02-15 15:23:58 PST
Created attachment 301663 [details] Proposed patch
Sam Weinig
Comment 3 2017-02-15 16:01:59 PST
Comment on attachment 301663 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=301663&action=review > Source/WebCore/ChangeLog:11 > + No new tests, no behavior change. > + > + * Modules/mediastream/MediaDevicesRequest.cpp: > + (WebCore::MediaDevicesRequest::start): ChangeLog could use more information, since you are doing more than just deleting a struct.
Eric Carlson
Comment 4 2017-02-15 16:39:21 PST
Created attachment 301672 [details] Patch for landing.
WebKit Commit Bot
Comment 5 2017-02-15 18:03:39 PST
Comment on attachment 301672 [details] Patch for landing. Clearing flags on attachment: 301672 Committed r212418: <http://trac.webkit.org/changeset/212418>
Note You need to log in before you can comment on or make changes to this bug.