Bug 168385

Summary: Web Inspector: Split console should be allowed when docked bottom on Elements/Resources/Debugger/Storage tabs
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2017-02-15 12:31:15 PST
Issue caused by r210911 <https://webkit.org/b/167075>.
Attachments
Patch (5.09 KB, patch)
2017-02-15 14:22 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2017-02-15 14:22:12 PST
Created attachment 301655 [details] Patch
Matt Baker
Comment 2 2017-02-15 14:26:54 PST
Comment on attachment 301655 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301655&action=review > Source/WebInspectorUI/UserInterface/Views/DebuggerTabContentView.js:52 > + get supportsSplitContentBrowser() This override and the three that follow could be eliminated by changing ContentView.prototype.supportsSplitContentBrowser back to `return true`. This should work because of your change above.
Devin Rousso
Comment 3 2017-02-15 14:34:39 PST
Comment on attachment 301655 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301655&action=review >> Source/WebInspectorUI/UserInterface/Views/DebuggerTabContentView.js:52 >> + get supportsSplitContentBrowser() > > This override and the three that follow could be eliminated by changing ContentView.prototype.supportsSplitContentBrowser back to `return true`. This should work because of your change above. I figured that it would be safer to make the default functionality be no split console when docked bottom and use a whitelist style of enabling tabs that we know work. Then again we don't have many tabs so this doesn't matter too much. If you would prefer it to be switched then I can change it :D
WebKit Commit Bot
Comment 4 2017-02-15 14:50:18 PST
Comment on attachment 301655 [details] Patch Clearing flags on attachment: 301655 Committed r212400: <http://trac.webkit.org/changeset/212400>
WebKit Commit Bot
Comment 5 2017-02-15 14:50:27 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.