Summary: | Remove JSDOMBinding.h | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||||||||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||||||||||
Status: | RESOLVED WONTFIX | ||||||||||||||||||
Severity: | Normal | CC: | ahmad.saleem792, ap, bfulgham, commit-queue, rniwa, saam | ||||||||||||||||
Priority: | P2 | ||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||
Attachments: |
|
Description
Sam Weinig
2017-02-15 11:46:37 PST
Created attachment 301641 [details]
Patch
Attachment 301641 [details] did not pass style-queue:
ERROR: Source/WebCore/ForwardingHeaders/runtime/GenericTypedArrayViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
ERROR: Source/WebCore/bindings/js/JSCSSValueCustom.cpp:29: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/bindings/js/JSIDBTransactionCustom.cpp:30: You should not add a blank line before implementation file's own header. [build/include_order] [4]
ERROR: Source/WebCore/ForwardingHeaders/runtime/JSGenericTypedArrayViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
ERROR: Source/WebCore/ForwardingHeaders/runtime/JSArrayBufferViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
Total errors found: 5 in 228 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 301641 [details] Patch Attachment 301641 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3123491 New failing tests: imported/w3c/web-platform-tests/WebIDL/current-realm.html Created attachment 301647 [details]
Archive of layout-test-results from ews112 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 301649 [details]
Patch
Attachment 301649 [details] did not pass style-queue:
ERROR: Source/WebKit/win/WebFrame.cpp:59: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/ForwardingHeaders/runtime/GenericTypedArrayViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
ERROR: Source/WebCore/bindings/js/JSCSSValueCustom.cpp:29: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/bindings/js/JSIDBTransactionCustom.cpp:30: You should not add a blank line before implementation file's own header. [build/include_order] [4]
ERROR: Source/WebCore/ForwardingHeaders/runtime/JSGenericTypedArrayViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
ERROR: Source/WebCore/ForwardingHeaders/runtime/JSArrayBufferViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
Total errors found: 6 in 229 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 301665 [details]
Patch
Attachment 301665 [details] did not pass style-queue:
ERROR: Source/WebKit/win/WebFrame.cpp:59: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/ForwardingHeaders/runtime/GenericTypedArrayViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
ERROR: Source/WebCore/bindings/js/JSCSSValueCustom.cpp:29: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/bindings/js/JSIDBTransactionCustom.cpp:30: You should not add a blank line before implementation file's own header. [build/include_order] [4]
ERROR: Source/WebCore/ForwardingHeaders/runtime/JSGenericTypedArrayViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
ERROR: Source/WebCore/ForwardingHeaders/runtime/JSArrayBufferViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
Total errors found: 6 in 229 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 301669 [details]
Patch
Attachment 301669 [details] did not pass style-queue:
ERROR: Source/WebCore/ForwardingHeaders/runtime/GenericTypedArrayViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
ERROR: Source/WebCore/bindings/js/JSCSSValueCustom.cpp:29: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/bindings/js/JSIDBTransactionCustom.cpp:30: You should not add a blank line before implementation file's own header. [build/include_order] [4]
ERROR: Source/WebCore/ForwardingHeaders/runtime/JSGenericTypedArrayViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
ERROR: Source/WebCore/ForwardingHeaders/runtime/JSArrayBufferViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
Total errors found: 5 in 228 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 301711 [details]
Patch
Attachment 301711 [details] did not pass style-queue:
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:125: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/ForwardingHeaders/runtime/GenericTypedArrayViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
ERROR: Source/WebCore/bindings/js/JSCSSValueCustom.cpp:29: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/bindings/js/JSIDBTransactionCustom.cpp:30: You should not add a blank line before implementation file's own header. [build/include_order] [4]
ERROR: Source/WebCore/ForwardingHeaders/runtime/JSGenericTypedArrayViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
ERROR: Source/WebCore/ForwardingHeaders/runtime/JSArrayBufferViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
Total errors found: 6 in 232 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 301822 [details]
Patch
Attachment 301822 [details] did not pass style-queue:
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMWindow.cpp"
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:125: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/ForwardingHeaders/runtime/GenericTypedArrayViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
ERROR: Source/WebCore/bindings/js/JSCSSValueCustom.cpp:29: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/bindings/js/JSIDBTransactionCustom.cpp:30: You should not add a blank line before implementation file's own header. [build/include_order] [4]
ERROR: Source/WebCore/ForwardingHeaders/runtime/JSGenericTypedArrayViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
ERROR: Source/WebCore/ForwardingHeaders/runtime/JSArrayBufferViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
Total errors found: 6 in 233 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 301822 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301822&action=review > Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:57 > -#include <JavaScriptCore/GenericTypedArrayViewInlines.h> > -#include <JavaScriptCore/JSGenericTypedArrayViewInlines.h> > +#include <runtime/GenericTypedArrayViewInlines.h> > +#include <runtime/JSGenericTypedArrayViewInlines.h> I think it's nicer to have JavaScriptCore in the include. (In reply to comment #15) > Comment on attachment 301822 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=301822&action=review > > > Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:57 > > -#include <JavaScriptCore/GenericTypedArrayViewInlines.h> > > -#include <JavaScriptCore/JSGenericTypedArrayViewInlines.h> > > +#include <runtime/GenericTypedArrayViewInlines.h> > > +#include <runtime/JSGenericTypedArrayViewInlines.h> > > I think it's nicer to have JavaScriptCore in the include. That is something that should be decided elsewhere. I am a bit at a loss of how to fix windows. It seems to want this inline heap function in most a lot of classes that the other ports don't need. It would be a shame to add JSCInlines.h to that many classes. I think different approach was taken and rather than removing it was gradually cleaned-up in following commits: https://github.com/WebKit/WebKit/commit/0ad65a8422677d1ead205b708f11e04a05cca8df https://github.com/WebKit/WebKit/commit/0a34d49d0bc07b3854be00ad0e733d921be67a97 https://github.com/WebKit/WebKit/commit/13ab11f4c219f217712f50c9bb6ffb0a5a06e1f2 Is something else needed or we can mark this as "RESOLVED WONTFIX"? Thanks! |