168383 – Remove JSDOMBinding.h

RESOLVED WONTFIX168383

Remove JSDOMBinding.h

https://bugs.webkit.org/show_bug.cgi?id=168383

Summary Remove JSDOMBinding.h

Sam Weinig

Reported 2017-02-15 11:46:37 PST

Remove JSDOMBinding.h

Attachments
Patch (177.10 KB, patch) 2017-02-15 11:54 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews112 for mac-elcapitan (1.52 MB, application/zip) 2017-02-15 13:19 PST, Build Bot	no flags	Details
Patch (177.93 KB, patch) 2017-02-15 14:06 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (178.13 KB, patch) 2017-02-15 15:31 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (179.47 KB, patch) 2017-02-15 15:58 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (181.62 KB, patch) 2017-02-15 22:50 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (183.17 KB, patch) 2017-02-16 14:11 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2017-02-15 11:54:10 PST

Created attachment 301641 [details] Patch

WebKit Commit Bot

Comment 2 2017-02-15 11:56:35 PST

Attachment 301641 [details] did not pass style-queue: ERROR: Source/WebCore/ForwardingHeaders/runtime/GenericTypedArrayViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] ERROR: Source/WebCore/bindings/js/JSCSSValueCustom.cpp:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/bindings/js/JSIDBTransactionCustom.cpp:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/ForwardingHeaders/runtime/JSGenericTypedArrayViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] ERROR: Source/WebCore/ForwardingHeaders/runtime/JSArrayBufferViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 5 in 228 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 3 2017-02-15 13:19:01 PST

Comment on attachment 301641 [details] Patch Attachment 301641 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3123491 New failing tests: imported/w3c/web-platform-tests/WebIDL/current-realm.html

Build Bot

Comment 4 2017-02-15 13:19:03 PST

Created attachment 301647 [details] Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Sam Weinig

Comment 5 2017-02-15 14:06:25 PST

Created attachment 301649 [details] Patch

WebKit Commit Bot

Comment 6 2017-02-15 14:11:11 PST

Attachment 301649 [details] did not pass style-queue: ERROR: Source/WebKit/win/WebFrame.cpp:59: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/ForwardingHeaders/runtime/GenericTypedArrayViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] ERROR: Source/WebCore/bindings/js/JSCSSValueCustom.cpp:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/bindings/js/JSIDBTransactionCustom.cpp:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/ForwardingHeaders/runtime/JSGenericTypedArrayViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] ERROR: Source/WebCore/ForwardingHeaders/runtime/JSArrayBufferViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 6 in 229 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 7 2017-02-15 15:31:39 PST

Created attachment 301665 [details] Patch

WebKit Commit Bot

Comment 8 2017-02-15 15:33:42 PST

Attachment 301665 [details] did not pass style-queue: ERROR: Source/WebKit/win/WebFrame.cpp:59: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/ForwardingHeaders/runtime/GenericTypedArrayViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] ERROR: Source/WebCore/bindings/js/JSCSSValueCustom.cpp:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/bindings/js/JSIDBTransactionCustom.cpp:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/ForwardingHeaders/runtime/JSGenericTypedArrayViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] ERROR: Source/WebCore/ForwardingHeaders/runtime/JSArrayBufferViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 6 in 229 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 9 2017-02-15 15:58:49 PST

Created attachment 301669 [details] Patch

WebKit Commit Bot

Comment 10 2017-02-15 16:03:27 PST

Attachment 301669 [details] did not pass style-queue: ERROR: Source/WebCore/ForwardingHeaders/runtime/GenericTypedArrayViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] ERROR: Source/WebCore/bindings/js/JSCSSValueCustom.cpp:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/bindings/js/JSIDBTransactionCustom.cpp:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/ForwardingHeaders/runtime/JSGenericTypedArrayViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] ERROR: Source/WebCore/ForwardingHeaders/runtime/JSArrayBufferViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 5 in 228 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 11 2017-02-15 22:50:56 PST

Created attachment 301711 [details] Patch

WebKit Commit Bot

Comment 12 2017-02-15 22:52:39 PST

Attachment 301711 [details] did not pass style-queue: ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:125: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/ForwardingHeaders/runtime/GenericTypedArrayViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] ERROR: Source/WebCore/bindings/js/JSCSSValueCustom.cpp:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/bindings/js/JSIDBTransactionCustom.cpp:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/ForwardingHeaders/runtime/JSGenericTypedArrayViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] ERROR: Source/WebCore/ForwardingHeaders/runtime/JSArrayBufferViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 6 in 232 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 13 2017-02-16 14:11:23 PST

Created attachment 301822 [details] Patch

WebKit Commit Bot

Comment 14 2017-02-16 14:14:51 PST

Attachment 301822 [details] did not pass style-queue: WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMWindow.cpp" ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:125: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/ForwardingHeaders/runtime/GenericTypedArrayViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] ERROR: Source/WebCore/bindings/js/JSCSSValueCustom.cpp:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/bindings/js/JSIDBTransactionCustom.cpp:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/ForwardingHeaders/runtime/JSGenericTypedArrayViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] ERROR: Source/WebCore/ForwardingHeaders/runtime/JSArrayBufferViewInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 6 in 233 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alex Christensen

Comment 15 2017-02-16 14:17:29 PST

Comment on attachment 301822 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301822&action=review > Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:57 > -#include <JavaScriptCore/GenericTypedArrayViewInlines.h> > -#include <JavaScriptCore/JSGenericTypedArrayViewInlines.h> > +#include <runtime/GenericTypedArrayViewInlines.h> > +#include <runtime/JSGenericTypedArrayViewInlines.h> I think it's nicer to have JavaScriptCore in the include.

Sam Weinig

Comment 16 2017-02-17 09:43:33 PST

(In reply to comment #15) > Comment on attachment 301822 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=301822&action=review > > > Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:57 > > -#include <JavaScriptCore/GenericTypedArrayViewInlines.h> > > -#include <JavaScriptCore/JSGenericTypedArrayViewInlines.h> > > +#include <runtime/GenericTypedArrayViewInlines.h> > > +#include <runtime/JSGenericTypedArrayViewInlines.h> > > I think it's nicer to have JavaScriptCore in the include. That is something that should be decided elsewhere. I am a bit at a loss of how to fix windows. It seems to want this inline heap function in most a lot of classes that the other ports don't need. It would be a shame to add JSCInlines.h to that many classes.

Ahmad Saleem

Comment 17 2022-08-02 13:16:40 PDT

I think different approach was taken and rather than removing it was gradually cleaned-up in following commits: https://github.com/WebKit/WebKit/commit/0ad65a8422677d1ead205b708f11e04a05cca8df https://github.com/WebKit/WebKit/commit/0a34d49d0bc07b3854be00ad0e733d921be67a97 https://github.com/WebKit/WebKit/commit/13ab11f4c219f217712f50c9bb6ffb0a5a06e1f2 Is something else needed or we can mark this as "RESOLVED WONTFIX"? Thanks!

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution WONTFIX

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component New Bugs

Assignee

Sam Weinig

Reported

2017-02-15 11:46 PST

Modified

2022-08-02 13:29 PDT History

CC List

6 users Show

URL

Keywords

Depends on

Blocks