Bug 168367 – Execute pending scripts asynchronously after stylesheet loads complete

• Component: DOM
• Status: RESOLVED FIXED

[Antti Koivisto]

Execution is currently synchronous creating various problems.

[Antti Koivisto]

Created attachment 301614 [details]
patch

[Antti Koivisto]

Created attachment 301616 [details]
patch

[Antti Koivisto]

Created attachment 301617 [details]
patch

[Build Bot]

Comment on attachment 301617 [details]
patch

Attachment 301617 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3122186

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 301619 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 301617 [details]
patch

Attachment 301617 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3122196

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 301620 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 301617 [details]
patch

Attachment 301617 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3122192

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 301621 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 301617 [details]
patch

Attachment 301617 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3122232

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 301625 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Antti Koivisto]

Created attachment 301640 [details]
patch

[Build Bot]

Comment on attachment 301640 [details]
patch

Attachment 301640 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3123877

New failing tests:
fast/lists/w3-css3-list-styles-alphabetic.html
fast/css-grid-layout/absolute-positioning-definite-sizes.html
fast/css/stylesheet-layout-with-pending-paint.html

[Build Bot]

Created attachment 301653 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 301640 [details]
patch

Attachment 301640 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3123882

New failing tests:
fast/css-grid-layout/absolute-positioning-definite-sizes.html
fast/css/stylesheet-layout-with-pending-paint.html

[Build Bot]

Created attachment 301654 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 301640 [details]
patch

Attachment 301640 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3123879

New failing tests:
fast/lists/w3-css3-list-styles-alphabetic.html
inspector/page/searchInResources.html
fast/css/stylesheet-layout-with-pending-paint.html

[Build Bot]

Created attachment 301656 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 301640 [details]
patch

Attachment 301640 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3124702

New failing tests:
fast/css/stylesheet-layout-with-pending-paint.html

[Build Bot]

Created attachment 301670 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 301640 [details]
patch

Attachment 301640 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3124534

New failing tests:
fast/css/stylesheet-layout-with-pending-paint.html

[Build Bot]

Created attachment 301687 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Antti Koivisto]

Created attachment 301732 [details]
patch

[Antti Koivisto]

Created attachment 301740 [details]
patch

[Antti Koivisto]

Created attachment 301750 [details]
patch

[Build Bot]

Comment on attachment 301750 [details]
patch

Attachment 301750 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3132976

New failing tests:
fast/lists/w3-css3-list-styles-alphabetic.html

[Build Bot]

Created attachment 301754 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 301750 [details]
patch

Attachment 301750 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3132985

New failing tests:
fast/lists/w3-css3-list-styles-alphabetic.html
inspector/page/searchInResources.html

[Build Bot]

Created attachment 301757 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 301750 [details]
patch

Attachment 301750 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3133111

New failing tests:
fast/lists/w3-css3-list-styles-alphabetic.html

[Build Bot]

Created attachment 301758 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Antti Koivisto]

Created attachment 301769 [details]
patch

[Andreas Kling]

Comment on attachment 301769 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301769&action=review

r=me

> Source/WebCore/ChangeLog:25
> +        * dom/Document.cpp:
> +        (WebCore::Document::Document):
> +        (WebCore::Document::recalcStyle):
> +
> +            Trigger scroll to anchor at the end of style resolution instead of when style sheet load completes.

As discussed on IRC, maybe we can do this in a separate change? I also wonder if we could do this as a post-layout task.

[Antti Koivisto]

rdar://problem/30561379

[Antti Koivisto]

Created attachment 301794 [details]
patch

[Build Bot]

Comment on attachment 301794 [details]
patch

Attachment 301794 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3134531

New failing tests:
http/tests/security/move-iframe-within-focus-handler-inside-removal.html

[Build Bot]

Created attachment 301807 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 301794 [details]
patch

Attachment 301794 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3134568

New failing tests:
http/tests/security/move-iframe-within-focus-handler-inside-removal.html

[Build Bot]

Created attachment 301811 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Antti Koivisto]

Created attachment 301812 [details]
patch

[WebKit Commit Bot]

Comment on attachment 301812 [details]
patch

Clearing flags on attachment: 301812

Committed r212463: <http://trac.webkit.org/changeset/212463>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 168526

[Antti Koivisto]

[Antti Koivisto]

Created attachment 302072 [details]
patch

[WebKit Commit Bot]

Comment on attachment 302072 [details]
patch

Clearing flags on attachment: 302072

Committed r212614: <http://trac.webkit.org/changeset/212614>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.