Bug 168367

Summary: Execute pending scripts asynchronously after stylesheet loads complete
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, dbates, esprehn+autocc, gyuyoung.kim, japhet, kangil.han, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 168526    
Bug Blocks:    
Attachments:
Description Flags
patch
none
patch
none
patch
buildbot: commit-queue-
Archive of layout-test-results from ews100 for mac-elcapitan
none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2
none
Archive of layout-test-results from ews115 for mac-elcapitan
none
Archive of layout-test-results from ews125 for ios-simulator-wk2
none
patch
buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-elcapitan
none
Archive of layout-test-results from ews106 for mac-elcapitan-wk2
none
Archive of layout-test-results from ews113 for mac-elcapitan
none
Archive of layout-test-results from ews123 for ios-simulator-wk2
none
Archive of layout-test-results from ews122 for ios-simulator-wk2
none
patch
none
patch
none
patch
buildbot: commit-queue-
Archive of layout-test-results from ews100 for mac-elcapitan
none
Archive of layout-test-results from ews113 for mac-elcapitan
none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2
none
patch
kling: review+
patch
buildbot: commit-queue-
Archive of layout-test-results from ews107 for mac-elcapitan-wk2
none
Archive of layout-test-results from ews123 for ios-simulator-wk2
none
patch
none
patch none

Description Antti Koivisto 2017-02-15 06:38:15 PST
Execution is currently synchronous creating various problems.
Comment 1 Antti Koivisto 2017-02-15 06:40:48 PST
Created attachment 301614 [details]
patch
Comment 2 Antti Koivisto 2017-02-15 07:18:12 PST
Created attachment 301616 [details]
patch
Comment 3 Antti Koivisto 2017-02-15 07:30:29 PST
Created attachment 301617 [details]
patch
Comment 4 Build Bot 2017-02-15 08:31:28 PST
Comment on attachment 301617 [details]
patch

Attachment 301617 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3122186

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2017-02-15 08:31:32 PST
Created attachment 301619 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 Build Bot 2017-02-15 08:35:55 PST
Comment on attachment 301617 [details]
patch

Attachment 301617 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3122196

Number of test failures exceeded the failure limit.
Comment 7 Build Bot 2017-02-15 08:35:59 PST
Created attachment 301620 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 8 Build Bot 2017-02-15 08:39:42 PST
Comment on attachment 301617 [details]
patch

Attachment 301617 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3122192

Number of test failures exceeded the failure limit.
Comment 9 Build Bot 2017-02-15 08:39:47 PST
Created attachment 301621 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 10 Build Bot 2017-02-15 09:13:37 PST
Comment on attachment 301617 [details]
patch

Attachment 301617 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3122232

Number of test failures exceeded the failure limit.
Comment 11 Build Bot 2017-02-15 09:13:50 PST
Created attachment 301625 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 12 Antti Koivisto 2017-02-15 11:49:25 PST
Created attachment 301640 [details]
patch
Comment 13 Build Bot 2017-02-15 14:14:48 PST
Comment on attachment 301640 [details]
patch

Attachment 301640 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3123877

New failing tests:
fast/lists/w3-css3-list-styles-alphabetic.html
fast/css-grid-layout/absolute-positioning-definite-sizes.html
fast/css/stylesheet-layout-with-pending-paint.html
Comment 14 Build Bot 2017-02-15 14:14:55 PST
Created attachment 301653 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 15 Build Bot 2017-02-15 14:18:50 PST
Comment on attachment 301640 [details]
patch

Attachment 301640 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3123882

New failing tests:
fast/css-grid-layout/absolute-positioning-definite-sizes.html
fast/css/stylesheet-layout-with-pending-paint.html
Comment 16 Build Bot 2017-02-15 14:18:53 PST
Created attachment 301654 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 17 Build Bot 2017-02-15 14:22:43 PST
Comment on attachment 301640 [details]
patch

Attachment 301640 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3123879

New failing tests:
fast/lists/w3-css3-list-styles-alphabetic.html
inspector/page/searchInResources.html
fast/css/stylesheet-layout-with-pending-paint.html
Comment 18 Build Bot 2017-02-15 14:22:49 PST
Created attachment 301656 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 19 Build Bot 2017-02-15 16:17:51 PST
Comment on attachment 301640 [details]
patch

Attachment 301640 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3124702

New failing tests:
fast/css/stylesheet-layout-with-pending-paint.html
Comment 20 Build Bot 2017-02-15 16:17:59 PST
Created attachment 301670 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 21 Build Bot 2017-02-15 18:52:15 PST
Comment on attachment 301640 [details]
patch

Attachment 301640 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3124534

New failing tests:
fast/css/stylesheet-layout-with-pending-paint.html
Comment 22 Build Bot 2017-02-15 18:52:20 PST
Created attachment 301687 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 23 Antti Koivisto 2017-02-16 03:11:28 PST
Created attachment 301732 [details]
patch
Comment 24 Antti Koivisto 2017-02-16 04:07:34 PST
Created attachment 301740 [details]
patch
Comment 25 Antti Koivisto 2017-02-16 05:13:26 PST
Created attachment 301750 [details]
patch
Comment 26 Build Bot 2017-02-16 06:11:03 PST
Comment on attachment 301750 [details]
patch

Attachment 301750 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3132976

New failing tests:
fast/lists/w3-css3-list-styles-alphabetic.html
Comment 27 Build Bot 2017-02-16 06:11:08 PST
Created attachment 301754 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 28 Build Bot 2017-02-16 06:22:03 PST
Comment on attachment 301750 [details]
patch

Attachment 301750 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3132985

New failing tests:
fast/lists/w3-css3-list-styles-alphabetic.html
inspector/page/searchInResources.html
Comment 29 Build Bot 2017-02-16 06:22:08 PST
Created attachment 301757 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 30 Build Bot 2017-02-16 06:50:26 PST
Comment on attachment 301750 [details]
patch

Attachment 301750 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3133111

New failing tests:
fast/lists/w3-css3-list-styles-alphabetic.html
Comment 31 Build Bot 2017-02-16 06:50:33 PST
Created attachment 301758 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 32 Antti Koivisto 2017-02-16 08:27:24 PST
Created attachment 301769 [details]
patch
Comment 33 Andreas Kling 2017-02-16 11:50:12 PST
Comment on attachment 301769 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301769&action=review

r=me

> Source/WebCore/ChangeLog:25
> +        * dom/Document.cpp:
> +        (WebCore::Document::Document):
> +        (WebCore::Document::recalcStyle):
> +
> +            Trigger scroll to anchor at the end of style resolution instead of when style sheet load completes.

As discussed on IRC, maybe we can do this in a separate change? I also wonder if we could do this as a post-layout task.
Comment 34 Antti Koivisto 2017-02-16 11:58:31 PST
rdar://problem/30561379
Comment 35 Antti Koivisto 2017-02-16 12:04:13 PST
Created attachment 301794 [details]
patch
Comment 36 Build Bot 2017-02-16 13:13:51 PST
Comment on attachment 301794 [details]
patch

Attachment 301794 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3134531

New failing tests:
http/tests/security/move-iframe-within-focus-handler-inside-removal.html
Comment 37 Build Bot 2017-02-16 13:13:56 PST
Created attachment 301807 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 38 Build Bot 2017-02-16 13:27:22 PST
Comment on attachment 301794 [details]
patch

Attachment 301794 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3134568

New failing tests:
http/tests/security/move-iframe-within-focus-handler-inside-removal.html
Comment 39 Build Bot 2017-02-16 13:27:27 PST
Created attachment 301811 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 40 Antti Koivisto 2017-02-16 13:27:52 PST
Created attachment 301812 [details]
patch
Comment 41 WebKit Commit Bot 2017-02-16 14:06:13 PST
Comment on attachment 301812 [details]
patch

Clearing flags on attachment: 301812

Committed r212463: <http://trac.webkit.org/changeset/212463>
Comment 42 WebKit Commit Bot 2017-02-16 14:06:22 PST
All reviewed patches have been landed.  Closing bug.
Comment 43 WebKit Commit Bot 2017-02-17 10:58:08 PST
Re-opened since this is blocked by bug 168526
Comment 44 Antti Koivisto 2017-02-17 11:02:56 PST

    
Comment 45 Antti Koivisto 2017-02-19 01:43:36 PST
Created attachment 302072 [details]
patch
Comment 46 WebKit Commit Bot 2017-02-19 04:13:51 PST
Comment on attachment 302072 [details]
patch

Clearing flags on attachment: 302072

Committed r212614: <http://trac.webkit.org/changeset/212614>
Comment 47 WebKit Commit Bot 2017-02-19 04:14:02 PST
All reviewed patches have been landed.  Closing bug.