168367 – Execute pending scripts asynchronously after stylesheet loads complete

RESOLVED FIXED 168367

Execute pending scripts asynchronously after stylesheet loads complete

https://bugs.webkit.org/show_bug.cgi?id=168367

Summary Execute pending scripts asynchronously after stylesheet loads complete

Antti Koivisto

Reported 2017-02-15 06:38:15 PST

Execution is currently synchronous creating various problems.

Attachments
patch (10.36 KB, patch) 2017-02-15 06:40 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (9.90 KB, patch) 2017-02-15 07:18 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (11.65 KB, patch) 2017-02-15 07:30 PST, Antti Koivisto	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-elcapitan (1.18 MB, application/zip) 2017-02-15 08:31 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.74 MB, application/zip) 2017-02-15 08:35 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews115 for mac-elcapitan (1.07 MB, application/zip) 2017-02-15 08:39 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (deleted) 2017-02-15 09:13 PST, Build Bot	no flags	Details
patch (11.91 KB, patch) 2017-02-15 11:49 PST, Antti Koivisto	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-elcapitan (1.06 MB, application/zip) 2017-02-15 14:14 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (934.10 KB, application/zip) 2017-02-15 14:18 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews113 for mac-elcapitan (1.84 MB, application/zip) 2017-02-15 14:22 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (952.11 KB, application/zip) 2017-02-15 16:17 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (686.28 KB, application/zip) 2017-02-15 18:52 PST, Build Bot	no flags	Details
patch (17.17 KB, patch) 2017-02-16 03:11 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (17.29 KB, patch) 2017-02-16 04:07 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (18.32 KB, patch) 2017-02-16 05:13 PST, Antti Koivisto	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-elcapitan (1.28 MB, application/zip) 2017-02-16 06:11 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews113 for mac-elcapitan (1.85 MB, application/zip) 2017-02-16 06:22 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (993.32 KB, application/zip) 2017-02-16 06:50 PST, Build Bot	no flags	Details
patch (19.75 KB, patch) 2017-02-16 08:27 PST, Antti Koivisto	kling: review+	Details Formatted Diff Diff
patch (19.11 KB, patch) 2017-02-16 12:04 PST, Antti Koivisto	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (1004.44 KB, application/zip) 2017-02-16 13:13 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (839.84 KB, application/zip) 2017-02-16 13:27 PST, Build Bot	no flags	Details
patch (19.78 KB, patch) 2017-02-16 13:27 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (19.85 KB, patch) 2017-02-19 01:43 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (24) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2017-02-15 06:40:48 PST

Created attachment 301614 [details] patch

Antti Koivisto

Comment 2 2017-02-15 07:18:12 PST

Created attachment 301616 [details] patch

Antti Koivisto

Comment 3 2017-02-15 07:30:29 PST

Created attachment 301617 [details] patch

Build Bot

Comment 4 2017-02-15 08:31:28 PST

Comment on attachment 301617 [details] patch Attachment 301617 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3122186 Number of test failures exceeded the failure limit.

Build Bot

Comment 5 2017-02-15 08:31:32 PST

Created attachment 301619 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 6 2017-02-15 08:35:55 PST

Comment on attachment 301617 [details] patch Attachment 301617 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3122196 Number of test failures exceeded the failure limit.

Build Bot

Comment 7 2017-02-15 08:35:59 PST

Created attachment 301620 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 8 2017-02-15 08:39:42 PST

Comment on attachment 301617 [details] patch Attachment 301617 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3122192 Number of test failures exceeded the failure limit.

Build Bot

Comment 9 2017-02-15 08:39:47 PST

Created attachment 301621 [details] Archive of layout-test-results from ews115 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 10 2017-02-15 09:13:37 PST

Comment on attachment 301617 [details] patch Attachment 301617 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3122232 Number of test failures exceeded the failure limit.

Build Bot

Comment 11 2017-02-15 09:13:50 PST

Created attachment 301625 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Antti Koivisto

Comment 12 2017-02-15 11:49:25 PST

Created attachment 301640 [details] patch

Build Bot

Comment 13 2017-02-15 14:14:48 PST

Comment on attachment 301640 [details] patch Attachment 301640 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3123877 New failing tests: fast/lists/w3-css3-list-styles-alphabetic.html fast/css-grid-layout/absolute-positioning-definite-sizes.html fast/css/stylesheet-layout-with-pending-paint.html

Build Bot

Comment 14 2017-02-15 14:14:55 PST

Created attachment 301653 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 15 2017-02-15 14:18:50 PST

Comment on attachment 301640 [details] patch Attachment 301640 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3123882 New failing tests: fast/css-grid-layout/absolute-positioning-definite-sizes.html fast/css/stylesheet-layout-with-pending-paint.html

Build Bot

Comment 16 2017-02-15 14:18:53 PST

Created attachment 301654 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 17 2017-02-15 14:22:43 PST

Comment on attachment 301640 [details] patch Attachment 301640 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3123879 New failing tests: fast/lists/w3-css3-list-styles-alphabetic.html inspector/page/searchInResources.html fast/css/stylesheet-layout-with-pending-paint.html

Build Bot

Comment 18 2017-02-15 14:22:49 PST

Created attachment 301656 [details] Archive of layout-test-results from ews113 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 19 2017-02-15 16:17:51 PST

Comment on attachment 301640 [details] patch Attachment 301640 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3124702 New failing tests: fast/css/stylesheet-layout-with-pending-paint.html

Build Bot

Comment 20 2017-02-15 16:17:59 PST

Created attachment 301670 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 21 2017-02-15 18:52:15 PST

Comment on attachment 301640 [details] patch Attachment 301640 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3124534 New failing tests: fast/css/stylesheet-layout-with-pending-paint.html

Build Bot

Comment 22 2017-02-15 18:52:20 PST

Created attachment 301687 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Antti Koivisto

Comment 23 2017-02-16 03:11:28 PST

Created attachment 301732 [details] patch

Antti Koivisto

Comment 24 2017-02-16 04:07:34 PST

Created attachment 301740 [details] patch

Antti Koivisto

Comment 25 2017-02-16 05:13:26 PST

Created attachment 301750 [details] patch

Build Bot

Comment 26 2017-02-16 06:11:03 PST

Comment on attachment 301750 [details] patch Attachment 301750 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3132976 New failing tests: fast/lists/w3-css3-list-styles-alphabetic.html

Build Bot

Comment 27 2017-02-16 06:11:08 PST

Created attachment 301754 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 28 2017-02-16 06:22:03 PST

Comment on attachment 301750 [details] patch Attachment 301750 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3132985 New failing tests: fast/lists/w3-css3-list-styles-alphabetic.html inspector/page/searchInResources.html

Build Bot

Comment 29 2017-02-16 06:22:08 PST

Created attachment 301757 [details] Archive of layout-test-results from ews113 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 30 2017-02-16 06:50:26 PST

Comment on attachment 301750 [details] patch Attachment 301750 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3133111 New failing tests: fast/lists/w3-css3-list-styles-alphabetic.html

Build Bot

Comment 31 2017-02-16 06:50:33 PST

Created attachment 301758 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Antti Koivisto

Comment 32 2017-02-16 08:27:24 PST

Created attachment 301769 [details] patch

Andreas Kling

Comment 33 2017-02-16 11:50:12 PST

Comment on attachment 301769 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=301769&action=review r=me > Source/WebCore/ChangeLog:25 > + * dom/Document.cpp: > + (WebCore::Document::Document): > + (WebCore::Document::recalcStyle): > + > + Trigger scroll to anchor at the end of style resolution instead of when style sheet load completes. As discussed on IRC, maybe we can do this in a separate change? I also wonder if we could do this as a post-layout task.

Antti Koivisto

Comment 34 2017-02-16 11:58:31 PST

rdar://problem/30561379

Antti Koivisto

Comment 35 2017-02-16 12:04:13 PST

Created attachment 301794 [details] patch

Build Bot

Comment 36 2017-02-16 13:13:51 PST

Comment on attachment 301794 [details] patch Attachment 301794 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3134531 New failing tests: http/tests/security/move-iframe-within-focus-handler-inside-removal.html

Build Bot

Comment 37 2017-02-16 13:13:56 PST

Created attachment 301807 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 38 2017-02-16 13:27:22 PST

Comment on attachment 301794 [details] patch Attachment 301794 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3134568 New failing tests: http/tests/security/move-iframe-within-focus-handler-inside-removal.html

Build Bot

Comment 39 2017-02-16 13:27:27 PST

Created attachment 301811 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Antti Koivisto

Comment 40 2017-02-16 13:27:52 PST

Created attachment 301812 [details] patch

WebKit Commit Bot

Comment 41 2017-02-16 14:06:13 PST

Comment on attachment 301812 [details] patch Clearing flags on attachment: 301812 Committed r212463: <http://trac.webkit.org/changeset/212463>

WebKit Commit Bot

Comment 42 2017-02-16 14:06:22 PST

All reviewed patches have been landed. Closing bug.

WebKit Commit Bot

Comment 43 2017-02-17 10:58:08 PST

Re-opened since this is blocked by bug 168526

Antti Koivisto

Comment 44 2017-02-17 11:02:56 PST

Antti Koivisto

Comment 45 2017-02-19 01:43:36 PST

Created attachment 302072 [details] patch

WebKit Commit Bot

Comment 46 2017-02-19 04:13:51 PST

Comment on attachment 302072 [details] patch Clearing flags on attachment: 302072 Committed r212614: <http://trac.webkit.org/changeset/212614>

WebKit Commit Bot

Comment 47 2017-02-19 04:14:02 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component DOM

Assignee

Nobody

Reported

2017-02-15 06:38 PST

Modified

2017-02-19 04:14 PST History

CC List

10 users Show

URL

Keywords InRadar

Depends on

168526

Blocks

Dependencies

tree graph