Summary: | ASSERTION FAILED: m_normalWorld->hasOneRef() under WorkerThread::stop | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||||||
Component: | JavaScriptCore | Assignee: | Joseph Pecoraro <joepeck> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | achristensen, ap, commit-queue, fpizlo, joepeck, rniwa, ryanhaddad, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Joseph Pecoraro
2017-02-14 20:47:30 PST
I'm able to reproduce this almost 100%. So don't hesitate to ask me questions. Hit this with imported/w3c/web-platform-tests/resource-timing/rt-resource-errors.html. Skipped the test on debug in http://trac.webkit.org/projects/webkit/changeset/212460 Same with imported/w3c/web-platform-tests/resource-timing/rt-resource-ignored.html http://trac.webkit.org/projects/webkit/changeset/212467 I ended up skipping the entire directory on Debug in http://trac.webkit.org/projects/webkit/changeset/212509 Seems to be related to WebCore::Performance destruction with EventListeners. Created attachment 302203 [details]
[PATCH] Proposed Fix
Created attachment 302206 [details]
[PATCH] Proposed Fix
Attachment 302206 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:9: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 302206 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=302206&action=review > LayoutTests/TestExpectations:314 > +webkit.org/b/161088 imported/w3c/web-platform-tests/resource-timing/resource-timing.html [ Pass Failure ] > webkit.org/b/168357 imported/w3c/web-platform-tests/resource-timing/rt-initiatorType-media.html [ Failure ] Why is this flaky failure?? Comment on attachment 302206 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=302206&action=review >> LayoutTests/TestExpectations:314 >> webkit.org/b/168357 imported/w3c/web-platform-tests/resource-timing/rt-initiatorType-media.html [ Failure ] > > Why is this flaky failure?? This is flakey because of: https://bugs.webkit.org/show_bug.cgi?id=168351 We are getting a timestamp from the NetworkProcess which may have been shifted compared to the WebProcess. So the WebProcess's timestamps and NetworkProcess timestamps may result in an incorrect order. > LayoutTests/TestExpectations:982 > webkit.org/b/168356 [ Debug ] imported/w3c/web-platform-tests/resource-timing [ Skip ] I meant to be removing this line, but horribly merged this with Git... Sorry! Created attachment 302218 [details]
[PATCH] For Landing
Comment on attachment 302218 [details] [PATCH] For Landing View in context: https://bugs.webkit.org/attachment.cgi?id=302218&action=review > LayoutTests/TestExpectations:-319 > -webkit.org/b/161176 [ Debug ] imported/w3c/web-platform-tests/url/url-setters.html [ Skip ] Wrong one... I'm really bad at this. Created attachment 302220 [details]
[PATCH] For Landing
Comment on attachment 302220 [details] [PATCH] For Landing Clearing flags on attachment: 302220 Committed r212698: <http://trac.webkit.org/changeset/212698> |