Summary: | Web Inspector: CSS variable uses that are unresolved should have an error or warning icon | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, hi, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
BJ Burg
2017-02-14 20:02:25 PST
Created attachment 302884 [details]
Patch
Created attachment 302885 [details]
[Image] After Patch is applied
Comment on attachment 302884 [details]
Patch
This is awesome. Will review in the morning.
Yes, very neat! The only thing that is weird to me is "Click to delete and open autocomplete". Click to delete I get. The open autocomplete part seems weird. (In reply to comment #5) > Yes, very neat! > > The only thing that is weird to me is "Click to delete and open > autocomplete". Click to delete I get. The open autocomplete part seems weird. I had the same initial reaction. Note that we also do this for invalid property values: "The value ā%sā is not supported for this property.\nClick to delete and open autocomplete." (In reply to comment #6) > (In reply to comment #5) > > Yes, very neat! > > > > The only thing that is weird to me is "Click to delete and open > > autocomplete". Click to delete I get. The open autocomplete part seems weird. > > I had the same initial reaction. Note that we also do this for invalid > property values: > > "The value ā%sā is not supported for this property.\nClick to delete and > open autocomplete." Exactly. I was thinking that in the case where the text was `margin: 10px var(--x) 5px;` the user wouldn't want the resulting text after click to be `margin: 10px 5px;`. I realize that this is what happens in actuality, but opening autocomplete suggests to the user that they replace the value with something valid instead of just getting rid of it. Comment on attachment 302884 [details] Patch Clearing flags on attachment: 302884 Committed r213187: <http://trac.webkit.org/changeset/213187> All reviewed patches have been landed. Closing bug. |