Bug 168342

Summary:

List of WebCore symbols to re-export from WebKitLegacy should be built automatically

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

WebKit Misc.

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, achristensen, ddkilzer, juergen, mitz, thorton

Priority:

Keywords:

InRadar

Version:

Safari 9

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=168158

Attachments:

Description	Flags
proposed patch	ap: commit-queue-
proposed patch	ap: commit-queue-
proposed patch	thorton: review+, ap: commit-queue-

Alexey Proskuryakov

Reported 2017-02-14 15:45:42 PST

We added a list of symbols to WebKit.iOS.exp, but this is not great. This list should be built automatically.

Attachments
proposed patch (8.67 KB, patch) 2017-02-14 15:58 PST, Alexey Proskuryakov	ap: commit-queue-	Details Formatted Diff Diff
proposed patch (8.69 KB, patch) 2017-02-15 17:00 PST, Alexey Proskuryakov	ap: commit-queue-	Details Formatted Diff Diff
proposed patch (8.69 KB, patch) 2017-02-15 17:33 PST, Alexey Proskuryakov	thorton: review+ ap: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2017-02-14 15:57:43 PST

rdar://problem/26182266

Alexey Proskuryakov

Comment 2 2017-02-14 15:58:33 PST

Created attachment 301561 [details] proposed patch This is pretty much my first time ever making non-trivial changes to a makefile, please review carefully.

Alexey Proskuryakov

Comment 3 2017-02-15 17:00:35 PST

Created attachment 301674 [details] proposed patch Updated to use DEPLOYMENT_TARGET_CLANG_FLAG_NAME (cf. <rdar://problem/30502789>).

Alexey Proskuryakov

Comment 4 2017-02-15 17:33:12 PST

Created attachment 301679 [details] proposed patch Oh, and fixing the typo in bug title too.

Alexey Proskuryakov

Comment 5 2017-02-20 10:34:34 PST

Committed http://trac.webkit.org/r212659

David Kilzer (:ddkilzer)

Comment 6 2017-02-20 12:56:31 PST

Comment on attachment 301679 [details] proposed patch This looks fine. I hope some day we can use XYZ_EXPORT macros to clean up some of the manual symbol lists.

Tim Horton

Comment 7 2020-06-10 22:36:17 PDT

Comment on attachment 301679 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=301679&action=review > Source/WebKit/WebKit.xcodeproj/project.pbxproj:3297 > + "$(BUILT_PRODUCTS_DIR)/DerivedSources/WebKitLegacy/ReexportedWebCoreSymbols_$(CURRENT_ARCH).exp", Seems like this got lost to history somehow

Tim Horton

Comment 8 2020-06-10 22:44:47 PDT

Probably https://trac.webkit.org/changeset/237047/webkit

Note You need to log in before you can comment on or make changes to this bug.