Summary: | List of WebCore symbols to re-export from WebKitLegacy should be built automatically | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||||
Component: | WebKit Misc. | Assignee: | Alexey Proskuryakov <ap> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | aakash_jain, achristensen, ddkilzer, juergen, mitz, thorton | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | Safari 9 | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=168158 | ||||||||||
Attachments: |
|
Description
Alexey Proskuryakov
2017-02-14 15:45:42 PST
Created attachment 301561 [details]
proposed patch
This is pretty much my first time ever making non-trivial changes to a makefile, please review carefully.
Created attachment 301674 [details] proposed patch Updated to use DEPLOYMENT_TARGET_CLANG_FLAG_NAME (cf. <rdar://problem/30502789>). Created attachment 301679 [details]
proposed patch
Oh, and fixing the typo in bug title too.
Committed http://trac.webkit.org/r212659 Comment on attachment 301679 [details]
proposed patch
This looks fine. I hope some day we can use XYZ_EXPORT macros to clean up some of the manual symbol lists.
Comment on attachment 301679 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=301679&action=review > Source/WebKit/WebKit.xcodeproj/project.pbxproj:3297 > + "$(BUILT_PRODUCTS_DIR)/DerivedSources/WebKitLegacy/ReexportedWebCoreSymbols_$(CURRENT_ARCH).exp", Seems like this got lost to history somehow |