Bug 168331

Summary: [WK2] Support data interaction on links
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit2Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, commit-queue, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
First pass
thorton: review+
Patch for landing
wenson_hsieh: commit-queue-
Patch for landing none

Description Wenson Hsieh 2017-02-14 13:23:22 PST 
Add infrastructure to support data interaction for links in WebKit2.
Comment 1 Wenson Hsieh 2017-02-14 13:25:53 PST 
<rdar://problem/30200837>
Comment 2 Wenson Hsieh 2017-02-14 18:06:08 PST 
Created attachment 301568 [details]
First pass
Comment 3 Tim Horton 2017-02-14 18:56:05 PST 
Comment on attachment 301568 [details]
First pass

View in context: https://bugs.webkit.org/attachment.cgi?id=301568&action=review

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:2554
> +    info.adjustedPoint = adjustedPoint;

'adjustedPoint' is a bit vague.

> Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm:98
> +        RetainPtr<DataInteractionSimulator> dataInteractionSimulator = [[DataInteractionSimulator alloc] initWithWebView:webView.get() startLocation:CGPointMake(100, 100) endLocation:CGPointMake(100, 300)];

Leaks

> Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm:111
> +        RetainPtr<DataInteractionSimulator> dataInteractionSimulator = [[DataInteractionSimulator alloc] initWithWebView:webView.get() startLocation:CGPointMake(100, 100) endLocation:CGPointMake(100, 300)];

Leaks
Comment 4 Wenson Hsieh 2017-02-14 20:20:06 PST 
Created attachment 301575 [details]
Patch for landing
Comment 5 Wenson Hsieh 2017-02-14 20:30:09 PST 
Created attachment 301576 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2017-02-14 21:07:27 PST 
Comment on attachment 301576 [details]
Patch for landing

Clearing flags on attachment: 301576

Committed r212342: <http://trac.webkit.org/changeset/212342>