Bug 168331 - [WK2] Support data interaction on links
Summary: [WK2] Support data interaction on links
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-14 13:23 PST by Wenson Hsieh
Modified: 2017-02-16 09:31 PST (History)
5 users (show)

See Also:


Attachments
First pass (36.06 KB, patch)
2017-02-14 18:06 PST, Wenson Hsieh
thorton: review+
Details | Formatted Diff | Diff
Patch for landing (36.07 KB, patch)
2017-02-14 20:20 PST, Wenson Hsieh
wenson_hsieh: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (36.21 KB, patch)
2017-02-14 20:30 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2017-02-14 13:23:22 PST
Add infrastructure to support data interaction for links in WebKit2.
Comment 1 Wenson Hsieh 2017-02-14 13:25:53 PST
<rdar://problem/30200837>
Comment 2 Wenson Hsieh 2017-02-14 18:06:08 PST
Created attachment 301568 [details]
First pass
Comment 3 Tim Horton 2017-02-14 18:56:05 PST
Comment on attachment 301568 [details]
First pass

View in context: https://bugs.webkit.org/attachment.cgi?id=301568&action=review

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:2554
> +    info.adjustedPoint = adjustedPoint;

'adjustedPoint' is a bit vague.

> Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm:98
> +        RetainPtr<DataInteractionSimulator> dataInteractionSimulator = [[DataInteractionSimulator alloc] initWithWebView:webView.get() startLocation:CGPointMake(100, 100) endLocation:CGPointMake(100, 300)];

Leaks

> Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm:111
> +        RetainPtr<DataInteractionSimulator> dataInteractionSimulator = [[DataInteractionSimulator alloc] initWithWebView:webView.get() startLocation:CGPointMake(100, 100) endLocation:CGPointMake(100, 300)];

Leaks
Comment 4 Wenson Hsieh 2017-02-14 20:20:06 PST
Created attachment 301575 [details]
Patch for landing
Comment 5 Wenson Hsieh 2017-02-14 20:30:09 PST
Created attachment 301576 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2017-02-14 21:07:27 PST
Comment on attachment 301576 [details]
Patch for landing

Clearing flags on attachment: 301576

Committed r212342: <http://trac.webkit.org/changeset/212342>