Bug 168322

Summary: [GStreamer] Implement MediaPlayerPrivate::hasSingleSecurityOrigin()
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply
Priority: P2 Keywords: Gtk, LayoutTestFailure
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=168359
Attachments:
Description Flags
Patch
none
Patch zan: review+

Carlos Garcia Campos
Reported 2017-02-14 08:16:12 PST
It currently returns true unconditionally.
Attachments
Patch (9.68 KB, patch)
2017-02-14 08:20 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch (9.70 KB, patch)
2017-02-14 08:26 PST, Carlos Garcia Campos 		zan: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-02-14 08:20:39 PST
Created attachment 301503 [details] Patch
Carlos Garcia Campos
Comment 2 2017-02-14 08:26:27 PST
Created attachment 301504 [details] Patch
Zan Dobersek
Comment 3 2017-02-14 23:28:20 PST
Comment on attachment 301504 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301504&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1440 > + return resolvedOrigin->isSameSchemeHostPort(requestedOrigin.get()); Why isSameSchemeHostPort(), and not e.g. canAccess() or isSameOriginAs()? Is this specified anywhere, or is the Mac port doing this the same way?
Carlos Garcia Campos
Comment 4 2017-02-14 23:30:42 PST
(In reply to comment #3) > Comment on attachment 301504 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=301504&action=review > > > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1440 > > + return resolvedOrigin->isSameSchemeHostPort(requestedOrigin.get()); > > Why isSameSchemeHostPort(), and not e.g. canAccess() or isSameOriginAs()? Is > this specified anywhere, or is the Mac port doing this the same way? I just copied what other ports do.
Zan Dobersek
Comment 5 2017-02-14 23:38:20 PST
Comment on attachment 301504 [details] Patch OK. Have Calvaris have a look at it, even if it's after the patch lands.
Carlos Garcia Campos
Comment 6 2017-02-14 23:44:57 PST
(In reply to comment #5) > Comment on attachment 301504 [details] > Patch > > OK. Have Calvaris have a look at it, even if it's after the patch lands. Sure, thanks!
Carlos Garcia Campos
Comment 7 2017-02-14 23:46:37 PST
Committed r212349: <http://trac.webkit.org/changeset/212349>
Note You need to log in before you can comment on or make changes to this bug.