Summary: | [GTK] Add two new buildbots that build-only test on Debian stable and Ubuntu LTS | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> | ||||
Component: | Tools / Tests | Assignee: | Carlos Alberto Lopez Perez <clopez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, annulen, ap, bugs-noreply, dbates, lforschler, mcatanzaro, mrobinson, ossy | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 168323 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Carlos Alberto Lopez Perez
2017-02-14 08:15:51 PST
Created attachment 301703 [details]
Patch
Comment on attachment 301703 [details] Patch Clearing flags on attachment: 301703 Committed r212429: <http://trac.webkit.org/changeset/212429> All reviewed patches have been landed. Closing bug. IMHO name of "--default-cmake-features" argument does not imply it is disabling JHBuild. (In reply to comment #4) > IMHO name of "--default-cmake-features" argument does not imply it is > disabling JHBuild. You can build webkit with the jhbuild and --default-cmake-features, or you can build webkit without jhbuild and --default-cmake-features. All possible combinations are supported. But we want this bots to run without jhbuild, so we can be sure webkit remains build-able on the base configuration using only the distribution dependencies. Checking for this argument on the buildbot config *and* for the gtk port on the buildbot config in order to decide if disable the jhbuild step is not ideal. But i don't think there is ideal solution here. If we add a explicit optional argument to disable jhbuild, then we have to take care of filtering that argument on the build step, as otherwise it would be passed to the build... causing the step to fail. Committed r212437: <http://trac.webkit.org/changeset/212437> |