Bug 168304

Summary: Use a set instead of a list for tests when parsing expectations
Product: WebKit Reporter: Florian Bruhin <webkit.org>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, commit-queue, glenn, lforschler, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 50635    
Attachments:
Description Flags
Patch none

Florian Bruhin
Reported 2017-02-14 04:49:19 PST
In _collect_matching_tests, a lot of membership tests are done on a giant list of strings. By making it a set instead, we can make those much faster, and there's no reason for it to be a list. With ~45k tests and some 1000 expectations, this reduces the parse time from 34s to 3s on my machine.
Attachments
Patch (2.70 KB, patch)
2017-02-14 04:55 PST, Florian Bruhin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Florian Bruhin
Comment 1 2017-02-14 04:55:27 PST
Created attachment 301487 [details] Patch
WebKit Commit Bot
Comment 2 2017-02-14 13:03:34 PST
Comment on attachment 301487 [details] Patch Clearing flags on attachment: 301487 Committed r212319: <http://trac.webkit.org/changeset/212319>
WebKit Commit Bot
Comment 3 2017-02-14 13:03:38 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.