Summary: | [GTK] Make DragImageRef a RefPtr instead of a plain pointer | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, bdakin, bugs-noreply, commit-queue | ||||||
Priority: | P2 | Keywords: | Gtk | ||||||
Version: | WebKit Local Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Carlos Garcia Campos
2017-02-14 01:22:52 PST
Created attachment 301476 [details]
Patch
Attachment 301476 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/gtk/DragImageGtk.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
ERROR: Source/WebCore/platform/gtk/DragImageGtk.cpp:64: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/platform/gtk/DragImageGtk.cpp:64: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 3 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 301477 [details]
Patch
Comment on attachment 301477 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301477&action=review > Source/WebCore/ChangeLog:8 > + Use RefPtr<cairo_surface_t> as DragImageRef for GTK+ port. We should add some rationale here. Committed r212287: <http://trac.webkit.org/changeset/212287> |