Bug 168296

Summary: [GTK] Make DragImageRef a RefPtr instead of a plain pointer
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, bugs-noreply, commit-queue
Priority: P2 Keywords: Gtk
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch svillar: review+

Carlos Garcia Campos
Reported 2017-02-14 01:22:52 PST
Maybe we can get rid of deleteDragImage() or even DragImageRef some day
Attachments
Patch (6.81 KB, patch)
2017-02-14 01:24 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch (6.82 KB, patch)
2017-02-14 01:30 PST, Carlos Garcia Campos 		svillar: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-02-14 01:24:43 PST
Created attachment 301476 [details] Patch
WebKit Commit Bot
Comment 2 2017-02-14 01:27:08 PST
Attachment 301476 [details] did not pass style-queue: ERROR: Source/WebCore/platform/gtk/DragImageGtk.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] ERROR: Source/WebCore/platform/gtk/DragImageGtk.cpp:64: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/gtk/DragImageGtk.cpp:64: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 3 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Carlos Garcia Campos
Comment 3 2017-02-14 01:30:52 PST
Created attachment 301477 [details] Patch
Sergio Villar Senin
Comment 4 2017-02-14 03:23:39 PST
Comment on attachment 301477 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301477&action=review > Source/WebCore/ChangeLog:8 > + Use RefPtr<cairo_surface_t> as DragImageRef for GTK+ port. We should add some rationale here.
Carlos Garcia Campos
Comment 5 2017-02-14 04:00:03 PST
Committed r212287: <http://trac.webkit.org/changeset/212287>
Note You need to log in before you can comment on or make changes to this bug.