Bug 168296

Summary:

[GTK] Make DragImageRef a RefPtr instead of a plain pointer

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, bdakin, bugs-noreply, commit-queue

Priority:

Keywords:

Gtk

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	svillar: review+

Description Carlos Garcia Campos 2017-02-14 01:22:52 PST

Maybe we can get rid of deleteDragImage() or even DragImageRef some day

Comment 1 Carlos Garcia Campos 2017-02-14 01:24:43 PST

Created attachment 301476 [details]
Patch

Comment 2 WebKit Commit Bot 2017-02-14 01:27:08 PST

Attachment 301476 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/gtk/DragImageGtk.cpp:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
ERROR: Source/WebCore/platform/gtk/DragImageGtk.cpp:64:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebCore/platform/gtk/DragImageGtk.cpp:64:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 3 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Carlos Garcia Campos 2017-02-14 01:30:52 PST

Created attachment 301477 [details]
Patch

Comment 4 Sergio Villar Senin 2017-02-14 03:23:39 PST

Comment on attachment 301477 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301477&action=review

> Source/WebCore/ChangeLog:8
> +        Use RefPtr<cairo_surface_t> as DragImageRef for GTK+ port.

We should add some rationale here.

Comment 5 Carlos Garcia Campos 2017-02-14 04:00:03 PST

Committed r212287: <http://trac.webkit.org/changeset/212287>