Bug 168291

Summary: [iOS] Form Validation Bubble should be sensitive to Dynamic Type
Product: WebKit Reporter: Jon Lee <jonlee>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, jcraig, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://developer.apple.com/reference/uikit/uifont/1619030-preferredfontfortextstyle?language=objc
See Also: https://bugs.webkit.org/show_bug.cgi?id=168271
Attachments:
Description Flags
Patch none

Jon Lee
Reported 2017-02-13 23:44:40 PST
When I change the text size through Settings > Display & Brightness, it should affect the size of the form text in the popover. Sort of the iOS version of 168271.
Attachments
Patch (7.96 KB, patch)
2017-02-15 09:05 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-02-13 23:45:15 PST
<rdar://problem/30508593>
Chris Dumez
Comment 2 2017-02-14 06:54:51 PST
Oh, is it different from the minimum font size setting? I will take a look.
Chris Dumez
Comment 3 2017-02-14 15:26:06 PST
Note that WebKit does not seem to obey this iOS setting for fonts on Web pages.
Jon Lee
Comment 5 2017-02-14 16:03:12 PST
(In reply to comment #3) > Note that WebKit does not seem to obey this iOS setting for fonts on Web > pages. That is correct, but this is UI, not web content. Use of -apple-system-* font-families will obey this setting.
Chris Dumez
Comment 6 2017-02-15 09:05:52 PST
Created attachment 301624 [details] Patch
Tim Horton
Comment 7 2017-02-15 09:44:48 PST
Comment on attachment 301624 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301624&action=review > LayoutTests/platform/ios-simulator/TestExpectations:2844 > +# Form validation popover does not obey minimum font size setting on iOS but Dynamic Type instead. Do we not have a way to test Dynamic Type adjustment?
Chris Dumez
Comment 8 2017-02-15 09:46:28 PST
(In reply to comment #7) > Comment on attachment 301624 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=301624&action=review > > > LayoutTests/platform/ios-simulator/TestExpectations:2844 > > +# Form validation popover does not obey minimum font size setting on iOS but Dynamic Type instead. > > Do we not have a way to test Dynamic Type adjustment? I could not find a programmatic way to do so.
WebKit Commit Bot
Comment 9 2017-02-15 10:14:05 PST
Comment on attachment 301624 [details] Patch Clearing flags on attachment: 301624 Committed r212375: <http://trac.webkit.org/changeset/212375>
WebKit Commit Bot
Comment 10 2017-02-15 10:14:14 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.