Bug 168283

Summary: Web Inspector: RTL: disclosure triangles in details section headers should be flipped and aligned right
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
SCREENSHOT (RTL)
none
Patch
none
Patch
bburg: review+
[Image] After Patch is applied
none
Patch
none
[Image] After Patch is applied none

Blaze Burg
Reported 2017-02-13 22:58:49 PST
Created attachment 301459 [details] SCREENSHOT (RTL) Probably don't need new art, just use a transform or something.
Attachments
SCREENSHOT (RTL) (172.68 KB, image/png)
2017-02-13 22:58 PST, Blaze Burg 		no flags
Details
Patch (6.09 KB, patch)
2017-02-23 10:52 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (8.62 KB, patch)
2017-02-23 15:36 PST, Devin Rousso 		bburg: review+
DetailsFormatted DiffDiff
[Image] After Patch is applied (33.51 KB, image/png)
2017-02-23 15:50 PST, Devin Rousso 		no flags
Details
Patch (8.18 KB, patch)
2017-02-24 23:32 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
[Image] After Patch is applied (28.22 KB, image/png)
2017-02-24 23:32 PST, Devin Rousso 		no flags
Details
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-02-13 22:59:12 PST
<rdar://problem/30508067>
Devin Rousso
Comment 2 2017-02-23 10:52:19 PST
Created attachment 302535 [details] Patch
Devin Rousso
Comment 3 2017-02-23 10:53:08 PST
Comment on attachment 302535 [details] Patch Whoops. Wrong bug :P
Devin Rousso
Comment 4 2017-02-23 15:36:05 PST
Created attachment 302590 [details] Patch
Devin Rousso
Comment 5 2017-02-23 15:50:15 PST
Created attachment 302594 [details] [Image] After Patch is applied
Blaze Burg
Comment 6 2017-02-24 21:50:49 PST
Comment on attachment 302590 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302590&action=review r=me Your "after" screenshot should show the collapsed disclosure triangle as well as the expanded one. > Source/WebInspectorUI/UserInterface/Views/DetailsSection.css:32 > + No need for extra newlines here.
Devin Rousso
Comment 7 2017-02-24 23:32:22 PST
Created attachment 302740 [details] Patch
Devin Rousso
Comment 8 2017-02-24 23:32:37 PST
Created attachment 302741 [details] [Image] After Patch is applied
WebKit Commit Bot
Comment 9 2017-02-25 00:07:10 PST
Comment on attachment 302740 [details] Patch Clearing flags on attachment: 302740 Committed r212998: <http://trac.webkit.org/changeset/212998>
WebKit Commit Bot
Comment 10 2017-02-25 00:07:15 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.