Bug 168275

Summary: Web Inspector: RTL: back/forward navigation buttons should not be flipped
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, bburg, commit-queue, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 172741    
Attachments:
Description Flags
SCREENSHOT
none
patch applied (LTR)
none
patch applied (RTL)
none
Patch
none
Patch none

Blaze Burg
Reported 2017-02-13 21:25:55 PST
Created attachment 301446 [details] SCREENSHOT It's customary for media controls and < > arrows to stay the same order in RTL layout. This is what Safari's back-forward buttons do.
Attachments
SCREENSHOT (159.78 KB, image/png)
2017-02-13 21:25 PST, Blaze Burg 		no flags
Details
patch applied (LTR) (68.59 KB, image/png)
2017-02-19 14:47 PST, Blaze Burg 		no flags
Details
patch applied (RTL) (54.14 KB, image/png)
2017-02-19 14:47 PST, Blaze Burg 		no flags
Details
Patch (6.56 KB, patch)
2017-02-19 14:52 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Patch (8.30 KB, patch)
2017-02-20 17:34 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-02-13 21:26:12 PST
<rdar://problem/30506897>
Blaze Burg
Comment 2 2017-02-14 00:01:12 PST
So, the buttons will be laid out like [ < ] [ > ], but the meaning is reversed: < will go forward, > will got backward. We might be able to do a CSS transform to flip the icon.
Blaze Burg
Comment 3 2017-02-19 14:47:15 PST
Created attachment 302091 [details] patch applied (LTR)
Blaze Burg
Comment 4 2017-02-19 14:47:33 PST
Created attachment 302092 [details] patch applied (RTL)
Blaze Burg
Comment 5 2017-02-19 14:52:29 PST
Created attachment 302093 [details] Patch
Matt Baker
Comment 6 2017-02-20 10:15:17 PST
Comment on attachment 302093 [details] Patch Back/forward buttons in the Console tab filter are broken (no longer visible) in LTR mode. Also in RTL mode the Console tab is pretty broken. Since this is a small patch it seems reasonable to address that too.
Blaze Burg
Comment 7 2017-02-20 17:29:54 PST
(In reply to comment #6) > Comment on attachment 302093 [details] > Patch > > Back/forward buttons in the Console tab filter are broken (no longer > visible) in LTR mode. Also in RTL mode the Console tab is pretty broken. > Since this is a small patch it seems reasonable to address that too. I'll fix console navigation bar in a separate patch. Trying to keep these small to avoid rebase issues. I also write these mainly at night when I have small time increments.
Blaze Burg
Comment 8 2017-02-20 17:34:01 PST
Created attachment 302210 [details] Patch
Matt Baker
Comment 9 2017-02-20 18:08:38 PST
Comment on attachment 302210 [details] Patch r=me
WebKit Commit Bot
Comment 10 2017-02-20 18:34:23 PST
Comment on attachment 302210 [details] Patch Clearing flags on attachment: 302210 Committed r212695: <http://trac.webkit.org/changeset/212695>
WebKit Commit Bot
Comment 11 2017-02-20 18:34:27 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.