Summary: | Call WKDestroyRenderingResources() on iOS when tabs are backgrounded | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, commit-queue, simon.fraser, thorton | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2017-02-13 15:46:14 PST
Created attachment 301404 [details]
Patch
Created attachment 301410 [details]
Patch
Comment on attachment 301404 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301404&action=review > Source/WebKit2/ChangeLog:9 > + There's code to call WKDestroyRenderingResources() on a 10s timer that exists for Mac, but on iOS Please unWKSI this. > Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:446 > + RELEASE_LOG(ProcessSuspension, "%p - WebProcess::destroyRenderingResources() took %.2fms", this, (endTime - startTime) * 1000.0); Would be neat if we had a thing for this. Attachment 301410 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:35: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 301410 [details] Patch Clearing flags on attachment: 301410 Committed r212260: <http://trac.webkit.org/changeset/212260> All reviewed patches have been landed. Closing bug. |