Bug 16817

Summary: [Gtk] Menu items need underscores
Product: WebKit Reporter: Christian Dywan <christian>
Component: WebKitGTKAssignee: Christian Dywan <christian>
Status: RESOLVED FIXED    
Severity: Major Keywords: Gtk
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Add underscores to appropriate menu labels. alp: review+

Christian Dywan
Reported 2008-01-10 09:51:33 PST
WebKitGtk should use underscores in menu items.
Attachments
Add underscores to appropriate menu labels. (10.58 KB, patch)
2008-01-11 04:21 PST, Christian Dywan 		alp: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Christian Dywan
Comment 1 2008-01-11 04:21:09 PST
Created attachment 18388 [details] Add underscores to appropriate menu labels. This patch adds underscores to all appropriate menu labels. - return String::fromUTF8(_("No file selected")); + return String::fromUTF8(_("(None)")); I changed this to match GtkFileChooserButton. - return String::fromUTF8(_("Search with MSN")); + return String::fromUTF8(_("_Search the Web")); I changed this because I don't think a random search engine provider is very useful in a generic item.
Alp Toker
Comment 2 2008-01-11 16:24:55 PST
Comment on attachment 18388 [details] Add underscores to appropriate menu labels. r=me Will add a couple more string fixes we noticed before landing.
Alp Toker
Comment 3 2008-01-11 16:26:04 PST
Landed in r29422.
Note You need to log in before you can comment on or make changes to this bug.